test: fix code

test/gui/.pylintrc

@@ -18,7 +18,15 @@ fail-under=10
 ignore-paths=^tst_.*/test.py$,
     shared/scripts/names.py,
     shared/scripts/custom_lib
-ignored-modules=squish,object,objectmaphelper,test
+ignored-modules=
+    squish,
+    object,
+    objectmaphelper,
+    test,
+    requests,
+    psutil,
+    urllib3,
+    custom_lib.syncstate,
 load-plugins=
     pylint.extensions.check_elif,
     pylint.extensions.bad_builtin,

test/gui/shared/scripts/helpers/SetupClientHelper.py

@@ -3,7 +3,7 @@
 from os import makedirs
 from os.path import exists, join
 import test
-import psutil  # pylint: disable=import-error
+import psutil
 import squish
 
 from helpers.SpaceHelper import get_space_id

test/gui/shared/scripts/helpers/SyncHelper.py

@@ -28,7 +28,7 @@
     # if the IDE fails to reference the script,
     # add the folder in Edit->Preferences->PyDev->Interpreters->Libraries
     sys.path.append(custom_lib)
-    from custom_lib.syncstate import SocketConnect  # pylint: disable=import-error
+    from custom_lib.syncstate import SocketConnect
 
 # socket messages
 socket_messages = []

test/gui/shared/scripts/helpers/UserHelper.py

@@ -60,7 +60,7 @@ def basic_auth_header(user=None, password=None):
 
 def getUserInfo(username, attribute):
     if username in test_users:
-        return test_users[username][attribute]
+        return getattr(test_users[username], attribute)
     if attribute == "password":
         return get_default_password()
     raise ValueError(f"Invalid user attribute: {attribute}")

test/gui/shared/scripts/helpers/WebUIHelper.py

@@ -24,13 +24,13 @@ def authorize_via_webui(username, password, login_type='oidc'):
         'OC_AUTH_URL': getClipboardText(),
     }
     proc = subprocess.run(
-        f'pnpm run {login_type}-login' % login_type,
+        f'pnpm run {login_type}-login',
         capture_output=True,
         shell=True,
         env={**os.environ, **envs},
         check=False,
     )
-    if not proc.returncode:
+    if proc.returncode:
         if proc.stderr.decode('utf-8'):
             raise OSError(proc.stderr.decode('utf-8'))
         raise OSError(proc.stdout.decode('utf-8'))

test/gui/shared/scripts/helpers/api/http_helper.py

@@ -1,5 +1,5 @@
-import requests  # pylint: disable=import-error
-import urllib3  # pylint: disable=import-error
+import requests
+import urllib3
 
 from helpers.UserHelper import basic_auth_header
 from helpers.ConfigHelper import get_config
@@ -9,6 +9,8 @@
 
 def send_request(url, method, body=None, headers=None, user=None, password=None):
     auth_header = basic_auth_header(user, password)
+    if not headers:
+        headers = {}
     headers.update(auth_header)
     return requests.request(
         method,

test/gui/shared/scripts/helpers/api/provisioning.py

@@ -32,24 +32,29 @@ def add_user_to_group(user, group_name):
 
 
 def create_user(username):
-    user = {}
     if username in UserHelper.test_users:
         user = UserHelper.test_users[username]
     else:
-        user = {
-            'username': username,
-            'displayname': username,
-            'email': f'{username}@mail.com',
-            'password': UserHelper.get_default_password(),
-        }
+        user = UserHelper.User(
+            username=username,
+            displayname=username,
+            email=f'{username}@mail.com',
+            password=UserHelper.get_default_password(),
+        )
 
     if get_config('ocis'):
         user_info = ocis.create_user(
-            user['username'], user['password'], user['displayname'], user['email']
+            user.username,
+            user.password,
+            user.displayname,
+            user.email,
         )
     else:
         user_info = oc.create_user(
-            user['username'], user['password'], user['displayname'], user['email']
+            user.username,
+            user.password,
+            user.displayname,
+            user.email,
         )
     created_users[username] = user_info