Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-only][full-ci] given step implementation of creating user in the server #11802

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[test-only][full-ci] given step implementation of creating user in the server #11802

merged 1 commit into from
Aug 29, 2024

Conversation

ishabaral
Copy link
Contributor

Description

Implemented on the server steps in the local test directory.
This Given step implementation creates user in the server with default attributes and without skeleton files.

Renamed step:

-Given user <user> has been created on the server with default attributes and without skeleton files
+Given user <user> has been created in the server with default attributes and without skeleton files

Part of #10432

@ishabaral ishabaral self-assigned this Aug 15, 2024
@ishabaral ishabaral mentioned this pull request Aug 16, 2024
Closed
3 tasks
@ishabaral ishabaral force-pushed the create_user_with_default_attributes branch 4 times, most recently from 89c602a to 5f8faa9 Compare August 22, 2024 10:24
@ishabaral ishabaral force-pushed the create_user_with_default_attributes branch 6 times, most recently from c3837b3 to a6360fc Compare August 28, 2024 10:13
@ishabaral ishabaral marked this pull request as ready for review August 28, 2024 11:03
@ishabaral ishabaral force-pushed the create_user_with_default_attributes branch 2 times, most recently from be8987f to 4842500 Compare August 28, 2024 11:17
saw-jan
saw-jan reviewed Aug 28, 2024
View reviewed changes
test/gui/shared/scripts/helpers/api/Provisioning.py Outdated Show resolved Hide resolved
test/gui/shared/scripts/helpers/api/Provisioning.py Outdated Show resolved Hide resolved
test/gui/shared/scripts/helpers/api/Provisioning.py Outdated Show resolved Hide resolved
test/gui/shared/scripts/helpers/api/oc10.py Outdated Show resolved Hide resolved
test/gui/shared/scripts/helpers/api/oc10.py Outdated Show resolved Hide resolved
test/gui/shared/scripts/helpers/api/oc10.py Outdated Show resolved Hide resolved
test/gui/shared/scripts/helpers/api/ocis.py Outdated Show resolved Hide resolved
test/gui/shared/scripts/helpers/api/ocis.py Outdated Show resolved Hide resolved
@saw-jan saw-jan changed the title [test-only][full-ci] given step implementation of creating user in the server with default attributes and without skeleton files [test-only][full-ci] given step implementation of creating user in the server Aug 28, 2024
@ishabaral ishabaral force-pushed the create_user_with_default_attributes branch 3 times, most recently from 7430d9c to 0bb3775 Compare August 29, 2024 05:40
@ishabaral ishabaral force-pushed the create_user_with_default_attributes branch from 0bb3775 to b5aa80a Compare August 29, 2024 06:22
@ishabaral ishabaral force-pushed the create_user_with_default_attributes branch from b5aa80a to bf9f64e Compare August 29, 2024 06:27
saw-jan
saw-jan approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan merged commit 356342c into master Aug 29, 2024
6 checks passed
@saw-jan saw-jan deleted the create_user_with_default_attributes branch August 29, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

Assignees

@ishabaral ishabaral

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishabaral @saw-jan