Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-only][full-ci] Given step implementation of sharing resource in the server #11881

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[test-only][full-ci] Given step implementation of sharing resource in the server #11881

merged 1 commit into from
Sep 17, 2024

Conversation

ishabaral
Copy link
Contributor

Description

Implemented on the server steps in the local test directory.
This Given step implementation shares file or folder in the server.

Renamed step:

-Given user "<user>" has shared file|folder <file|folder> on the server with user "<user>" with "<permission>" permission(s)
+Given user "<user>" has shared file|folder <file|folder> in the server with user "<user>" with "<permission>" permission(s)

Part of #10432

@ishabaral ishabaral self-assigned this Sep 13, 2024
@ishabaral ishabaral changed the title given step implementation of sharing file or folder in the server [test-only][full-ci] Given step implementation of sharing file or folder in the server Sep 13, 2024
@ishabaral ishabaral mentioned this pull request Sep 13, 2024
Closed
3 tasks
@ishabaral ishabaral force-pushed the share_a_folder_in_the_server branch 4 times, most recently from 0802ac2 to 7dd5e3b Compare September 16, 2024 08:52
@ishabaral ishabaral force-pushed the share_a_folder_in_the_server branch 2 times, most recently from babbef6 to 98f8574 Compare September 16, 2024 11:33
@ishabaral ishabaral marked this pull request as ready for review September 16, 2024 11:33
@ishabaral ishabaral force-pushed the share_a_folder_in_the_server branch 3 times, most recently from 5e45e51 to 77a37d9 Compare September 17, 2024 06:49
saw-jan
saw-jan approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan merged commit d6c4a93 into master Sep 17, 2024
6 checks passed
@saw-jan saw-jan deleted the share_a_folder_in_the_server branch September 17, 2024 08:19
@ishabaral ishabaral changed the title [test-only][full-ci] Given step implementation of sharing file or folder in the server [test-only][full-ci] Given step implementation of sharing resource in the server Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@ishabaral ishabaral

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishabaral @saw-jan