Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Share] It´s not possible to distinguish with whom you have shared something #20291

Closed
rperezb opened this issue Nov 4, 2015 · 26 comments · Fixed by #22611
Closed

[Share] It´s not possible to distinguish with whom you have shared something #20291

rperezb opened this issue Nov 4, 2015 · 26 comments · Fixed by #22611

Comments

@rperezb
Copy link

rperezb commented Nov 4, 2015

STEPS:
1.- Create 2 users, user1 and user2
2.- login as user1 and change its full name to user
3.- login as user2 and change its full name to user
4.- login as admin and select to share a file with user

CURRENT BEHAVIOR:
You don't know with whom user you are sharing something

screen shot 2015-11-04 at 11 23 01

EXPECTED BEHAVIOR:
Be able to distinguish the user with whom you have share.... ui input needed!

@rperezb
Copy link
Author

rperezb commented Nov 4, 2015

@jancborchardt @owncloud/designers

@rperezb
Copy link
Author

rperezb commented Nov 4, 2015

@MTRichards this is important for clients development.

We plan to show on the mobile apps and client the same user id as the one on the webinterface

fyi @rullzer @davivel @masensio @ggdiez @javiergonzper @nasli

@jancborchardt
Copy link
Member

The username shows on hover. In addition, to clear up this edge-case, we could show the username of people where the display name is duplicate in parentheses after the display name like so:

  • user (user1)
  • user (user2)

But only when there is a case of duplicate display names as this should be very rare.
However maybe it would be more intelligent to enforce unique display names and put out a warning if there are dupicates? cc @DeepDiver1975?

@MTRichards
Copy link
Contributor

Concur with Jan's answer if we can.

@MTRichards MTRichards added this to the 9.0-current milestone Nov 4, 2015
@MTRichards
Copy link
Contributor

Does the API also need to respond with both the username and display name so mobile and desktop can take advantage of it?

@rullzer
Copy link
Contributor

rullzer commented Nov 4, 2015

Does the API also need to respond with both the username and display name so mobile and desktop can take advantage of it?

Already does 😉

@MTRichards
Copy link
Contributor

Excellent, so this becomes a mobile and desktop item.
@dragotin @rperezb
So that we can handle internal sharing with users that have the same display name.

@rperezb
Copy link
Author

rperezb commented Nov 4, 2015

got it! thanks

@MorrisJobke
Copy link
Contributor

cc @michaelstingl

00004123

@MorrisJobke
Copy link
Contributor

API: #18234
API doc: owncloud-archive/documentation#1626

@MorrisJobke
Copy link
Contributor

well then we need to think about something generic. Since we can't assume the e-mail is set.

Correct. Therefore I would like to add either the full user object (and the handle this in the frontend) or and alternative more verbose label for the case there are multiple same labels.

@jancborchardt
Copy link
Member

Btw, this is actually a duplicate of #8194 from last year where I suggested exactly the same thing. ;)

@rullzer
Copy link
Contributor

rullzer commented Nov 11, 2015

@jancborchardt so just to be perfectly clear.

Assume we have 3 users:

  • id: user1, email: user1@foo.com, displayName: Bar
  • id: user2, email: user2@foo.com, displayName: Bar
  • id: user3, email: , displayName: Bar

And I share with all those users it whould show up as

@jancborchardt
Copy link
Member

Yep. Then of course we should also eventually have some system for mail address verification and ensuring it’s unique – see #7326

@jancborchardt
Copy link
Member

@rullzer wait – actually I think it should always be the user id, not the email address. As that can be confused with the remote sharing ID.

@rullzer
Copy link
Contributor

rullzer commented Nov 11, 2015

Yep. Then of course we should also eventually have some system for mail address verification and ensuring it’s unique – see #7326

Sure, but that is a separate issue

@rullzer wait – actually I think it should always be the user id, not the email address. As that can be confused with the remote sharing ID.

This will break in case of LDAP since that is an internal ID. That can be pretty random.

@MTRichards
Copy link
Contributor

@rullzer I like the solution. Good results guys.

@MTRichards
Copy link
Contributor

This will break in case of LDAP since that is an internal ID. That can be pretty random.

there is definitely an internal unique user ID, but the username and display ID are usually not so crazy...if I recall.

@blizzz

@bboule
Copy link

bboule commented Jan 7, 2016

Guys this seems like a feature request a, I wrong?

@MorrisJobke
Copy link
Contributor

Guys this seems like a feature request a, I wrong?

Correct (see the enhancement label in the sidebar ;))

@MTRichards
Copy link
Contributor

If I sum this up, the same displayname shows up as the same person, and you can't tell them apart.

Therefore, we do as @rullzer suggested with displayname, email if available, username in that order. If the UID is the username, that sucks but what else can we use?

For federated sharing, can we used the name of the remote server before username?

@nickvergessen
Copy link
Contributor

If the UID is the username, that sucks but what else can we use?

Well we at least know, that it is the same user. and then there should be only one user with this UID === username combination

@cdamken
Copy link
Contributor

cdamken commented Feb 23, 2016

I just took over the case 00004123 in SFDC, and its referred to this issue.

Guys this seems like a feature request a, I wrong?

I'm reading the customers request and he asked it since oC6,

Other customers have a similar solution with second display name like: https://github.com/owncloud/enterprise/issues/690 and https://github.com/owncloud/enterprise/issues/1088

In this case is Shibboleth an additional factor, I'm not sure if that is a difference

@MorrisJobke
Copy link
Contributor

Okay. 9.0 will contain a workaround. I think we nevertheless should handle this properly in the client side. I will open a ticket on this.

@MorrisJobke
Copy link
Contributor

#22652

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants