[WIP] Update doctrine/dbal to 2.5.1

[VicDeo]

Closes #13303
Depends on owncloud-archive/3rdparty#152

Scheduled for 8.1

[DeepDiver1975]

@VicDeo thx - can you please have a look at the failing unit tests? Looks like something changed which breaks on our side - THX

[VicDeo]

@DeepDiver1975 yes, there are breaking changes with index handling. https://github.com/owncloud/3rdparty/blob/dbal-251/doctrine/dbal/UPGRADE.md

Will have a look

[scrutinizer-notifier]

A new inspection was created.

[VicDeo]

@DeepDiver1975 This is what we call a breaking change: indexes with the same name are compared by some additional features

doctrine/dbal@c1eae73
doctrine/dbal@32fae86

An autoincrement field is always a primary index and according to a new 'smart' logic no more primary indexes are allowed for tables with autoincrement:
https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Schema/Table.php#L508

So there is a definition conflict between https://github.com/owncloud/core/blob/master/db_structure.xml#L1208 and https://github.com/owncloud/core/blob/master/db_structure.xml#L1245

[DeepDiver1975]

oh - brilliant!

[DeepDiver1975]

I'll have a look once 8.0 has left - THX @VicDeo

[DeepDiver1975]

@VicDeo did you find any solution already to these problem? This is kind of getting momentum - see #14003 - please put some prio on this - THX

[karlitschek]

How risky would be a 8.0.1 backport? #14003 Sounds not good.

[DeepDiver1975]

From my pov the risk depends on the amount of adjustments. Maybe a selective patch could be an option for oc8.0.1
But let's get 2.5.1 working first.

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9215/
Test FAILed.

[VicDeo]

Something went fubar here.
Resubmitted as #14119