Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax load groups in sidebar of users page #20493

Closed
wants to merge 1 commit into from

Conversation

PVince81
Copy link
Contributor

The sidebar contents is now loaded with ajax.

@nickvergessen that's the separated part

TODOs:

  • user count must be grey instead of black
  • "admin" group should say "Admins" (special case)

@PVince81 PVince81 added this to the 9.0-current milestone Nov 13, 2015
@PVince81
Copy link
Contributor Author

@blizzz is paginated loading of the group list even possible (LDAP) ?

@blizzz
Copy link
Contributor

blizzz commented Nov 13, 2015

is paginated loading of the group list even possible (LDAP) ?

Yes, of course. It only must be done the same way for the list on the left sidebare as well as for the group pickers. In the other PR i have seen you are aware of this, so all fine.

@PVince81 PVince81 changed the title Ajax load groups in users page Ajax load groups in sidebar of users page Nov 13, 2015
@PVince81
Copy link
Contributor Author

For the group pickers it will likely be a search field, so no real pagination / lazy loading of the next page. Well, unless the API supports it.

I'll have to dig into the API

@nickvergessen
Copy link
Contributor

I guess you need to tunnel the limit through until this method:
https://github.com/owncloud/core/blob/master/lib/private/group/metadata.php#L188-188

@PVince81 PVince81 force-pushed the users-ajaxloadgroups branch from 3e4aee6 to de4c530 Compare November 13, 2015 14:43
@PVince81
Copy link
Contributor Author

  • do not reload the sidebar contents when assigning/unassigning groups

@MorrisJobke
Copy link
Contributor

do not reload the sidebar contents when assigning/unassigning groups

Is this the only missing thing?

@MorrisJobke
Copy link
Contributor

Rebased.

@PVince81
Copy link
Contributor Author

Is this the only missing thing?

Possibly, but IIRC there are other glitches and inconsistencies.

@MorrisJobke MorrisJobke modified the milestones: 9.1-next, 9.0-current Mar 4, 2016
@PVince81 PVince81 modified the milestones: 9.2-next, 9.1-current May 30, 2016
@PVince81
Copy link
Contributor Author

Looks like Backbone collections with events would be of a great use here, considering that there are multiple views displaying similar information

@PVince81 PVince81 force-pushed the users-ajaxloadgroups branch from 528f70e to 8939110 Compare July 15, 2016 09:38
@PVince81
Copy link
Contributor Author

Ok, from what I see even master reloaded the sidebar group list with ajax when adding groups... something to fix separately.

This PR is already a good step forward.

To be done separately:

  • make the selection dropdowns use the ajax-loaded group list (done in [WIP] Ajax load groups in users page #10994 as follow up)
  • use some event system to update the counters in the group sidebar instead of reloading it fully.

Please review and test !

@VicDeo
Copy link
Member

VicDeo commented Aug 1, 2016

@PVince81

  • The input with a new group title should be cleared if group is created successfully
  • Click any group, only users of this group are displayed. There is no way to reset filter to show all users now.
  • Create a group, assign any user to it. Click group, user list is filtered. Now click a delete icon. Group is deleted but the filter is still applied.

Looks good apart of three points above

@PVince81 PVince81 modified the milestones: backlog, 10.0 Apr 6, 2017
@PVince81 PVince81 closed this Jul 19, 2017
@PVince81 PVince81 deleted the users-ajaxloadgroups branch July 19, 2017 10:04
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants