-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajax load groups in sidebar of users page #20493
Conversation
@blizzz is paginated loading of the group list even possible (LDAP) ? |
Yes, of course. It only must be done the same way for the list on the left sidebare as well as for the group pickers. In the other PR i have seen you are aware of this, so all fine. |
For the group pickers it will likely be a search field, so no real pagination / lazy loading of the next page. Well, unless the API supports it. I'll have to dig into the API |
I guess you need to tunnel the limit through until this method: |
3e4aee6
to
de4c530
Compare
|
Is this the only missing thing? |
de4c530
to
528f70e
Compare
Rebased. |
Possibly, but IIRC there are other glitches and inconsistencies. |
Looks like Backbone collections with events would be of a great use here, considering that there are multiple views displaying similar information |
528f70e
to
8939110
Compare
Ok, from what I see even master reloaded the sidebar group list with ajax when adding groups... something to fix separately. This PR is already a good step forward. To be done separately:
Please review and test ! |
8939110
to
67cea62
Compare
Looks good apart of three points above |
67cea62
to
e725bf7
Compare
e725bf7
to
e34d5fb
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The sidebar contents is now loaded with ajax.
@nickvergessen that's the separated part
TODOs: