Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce OCP\Migration\IRepairStep and adopt all repair steps to thi… #24199

Merged
merged 1 commit into from
Apr 26, 2016

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Apr 22, 2016

…s new interface - refs #24198
An new public api is defined OCP\Migration\IRepairStep - https://github.com/owncloud/core/pull/24199/files#diff-34802a4ab7d05fa78a2e53e6ef6bc177 and any output of an individual repair step implementation can be passed through methods of OCP\Migration\IOutput

interface IOutput {

    /**
     * @param string $message
     */
    public function info($message);

    /**
     * @param string $message
     */
    public function warning($message);

    /**
     * @param int $max
     */
    public function startProgress($max = 0);

    /**
     * @param int $step
     */
    public function advance($step = 1);

    /**
     * @param int $max
     */
    public function finishProgress();

}

@DeepDiver1975 DeepDiver1975 added this to the 9.1-current milestone Apr 22, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @PVince81, @nickvergessen and @rullzer to be potential reviewers

@@ -0,0 +1,61 @@
<?php
/**
* @author Vincent Petry <pvince81@owncloud.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I writing code in my sleep ? 😉

@PVince81
Copy link
Contributor

Code looks good, CLI upgrade did not explode 👍

@MorrisJobke
Copy link
Contributor

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 6d62a74 into master Apr 26, 2016
@MorrisJobke MorrisJobke deleted the ocp-repair branch April 26, 2016 06:47
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants