Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump phpseclib/phpseclib from 3.0.21 to 3.0.23 #40986

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public function run(IOutput $out) {
}

try {
/** @phan-suppress-next-line PhanUndeclaredMethod */
$rsaKey = RSACrypt::load($privKey, $pass)->withHash('sha1');
} catch (\phpseclib3\Exception\NoKeyLoadedException $e) {
$out->warning("Storage configuration with id = {$configId}: Cannot load private key, skipping");
Expand Down
1 change: 1 addition & 0 deletions apps/files_external/lib/Lib/RSAStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ public function retrieveData(string $token): PrivateKey {
$privateKey = $this->credentialsManager->retrieve($keyData['userId'], $keyData['rsaId']);
$password = $this->config->getSystemValue('secret', '');

/** @phan-suppress-next-line PhanUndeclaredMethod */
return RSA::load($privateKey, $password)->withHash('sha1');
}
}
6 changes: 6 additions & 0 deletions changelog/unreleased/PHPdependencies20230920onward
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Change: Update PHP dependencies

The following have been updated:
- phpseclib/phpseclib (3.0.21 to 3.0.23)

https://github.com/owncloud/core/pull/40986
12 changes: 6 additions & 6 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions core/Command/Integrity/SignApp.php
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
}

/** @var RSA $rsa */
/** @phan-suppress-next-line PhanUndeclaredMethod */
$rsa = RSA::load($privateKey)->withHash('sha1');
$x509 = new X509();
$certificate = $x509->loadX509($keyBundle);
Expand Down
1 change: 1 addition & 0 deletions core/Command/Integrity/SignCore.php
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
}

/** @var RSA $rsa */
/** @phan-suppress-next-line PhanUndeclaredMethod */
$rsa = RSA::load($privateKey)->withHash('sha1');
$x509 = new X509();
$certificate = $x509->loadX509($keyBundle);
Expand Down
1 change: 1 addition & 0 deletions lib/private/IntegrityCheck/Checker.php
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ private function verify($signaturePath, $basePath, $certificateCN, $force = fals
);
}

/** @phan-suppress-next-line PhanUndeclaredMethod */
$rsa = RSA::load($loadedCertificate['tbsCertificate']['subjectPublicKeyInfo']['subjectPublicKey'])
->withHash('sha1')
->withMGFHash('sha512')
Expand Down