Fix swift touch operation #7911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The touch() operation now uses "UpdateMetadata()" instead of "Update()" which doesn't clear the object's contents. This fixes syncing, as the sync client needs to use touch to update the object's mtime.
|
Code makes sense 👍 , don't have a swift install to test it with atm. |
|
I've tested it with the sync client 😄 |
|
The inspection completed: No new issues |
|
🚀 Test Passed. 🚀 |
|
looks good. not tested 👍 |
|
@karlitschek backport to stable6 ? |
|
yes. would be great. |
|
Backported to stable6 as 17e5c03 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The touch() operation now uses "UpdateMetadata()" instead of "Update()"
which doesn't clear the object's contents.
This fixes syncing, as the sync client needs to use touch to update the
object's mtime.
Should fix the syncing issue and "0 byte" issue mentionned in #7191
Please review/test @icewind1991 @yannickgrammont @joakimohman @leonardofln @ser72