Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a search engine #36

Closed
1 task done
oparoz opened this issue Feb 21, 2015 · 3 comments
Closed
1 task done

Implement a search engine #36

oparoz opened this issue Feb 21, 2015 · 3 comments

Comments

@oparoz
Copy link
Contributor

oparoz commented Feb 21, 2015

oC8 comes with a more efficient search engine, but the app is not yet plugged into it.

Thoughts on possible solutions

As soon as a search is started, the view and models should be cleared and thumbnails should be generated.

  • If we keep the current way of building the view, then nothing might show up until a row is full.
  • If we make it so that a search is authorised to ask the backend for one thumbnail as a time, then that backend may get flooded with requests (that's what the Files app is doing)

Prerequisites

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@theCalcaholic
Copy link

What do you mean by "a row is full"? A row of search results or generated Thumbnails?

@oparoz
Copy link
Contributor Author

oparoz commented Jun 11, 2015

This is the way it currently works

  1. We get a list of all media files we need to show
  2. We split the list in batches
  3. We show a row of thumbnails once all thumbnails for that row have been received

This works kind of OK when we know in advance what we need to show in the view (via step 1)

The search app is sending back results as soon as we type a few letters, but we wouldn't be able to show anything until we get the thumbnails from the server whereas the Files app is first building the DOM and then asking for thumbnails.

DeepDiver1975 added a commit that referenced this issue Jul 25, 2015
Rotate thumbnail when encryption is enabled
@oparoz oparoz added this to the backlog milestone Aug 31, 2015
@oparoz
Copy link
Contributor Author

oparoz commented Sep 4, 2016

This issue was moved to nextcloud/gallery#16

@oparoz oparoz closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants