Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[milestone/12.0.2] Milestone 12.0.2 #1230

Merged
merged 12 commits into from
Jun 27, 2023
Merged
43 changes: 43 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,46 @@
Changelog for ownCloud iOS Client [12.0.2] (2023-06-23)
=======================================
The following sections list the changes in ownCloud iOS Client 12.0.2 relevant to
ownCloud admins and users.

[12.0.2]: https://github.com/owncloud/ios-app/compare/milestone/12.0.1...milestone/12.0.2

Summary
-------

* Bugfix - Unable to authenticate using OpenID Connect: [#1219](https://github.com/owncloud/ios-app/issues/1219)
* Bugfix - Files.app: [#1223](https://github.com/owncloud/ios-app/pull/1223)
* Bugfix - Recent files view: [#1225](https://github.com/owncloud/ios-app/pull/1225)
* Bugfix - Attach files from third-party apps: [#1228](https://github.com/owncloud/ios-app/pull/1228)

Details
-------

* Bugfix - Unable to authenticate using OpenID Connect: [#1219](https://github.com/owncloud/ios-app/issues/1219)

It was not able to authenticate using OpenID Connect

https://github.com/owncloud/ios-app/issues/1219

* Bugfix - Files.app: [#1223](https://github.com/owncloud/ios-app/pull/1223)

Solves "Content unavailable" in Files.app

https://github.com/owncloud/ios-app/pull/1223

* Bugfix - Recent files view: [#1225](https://github.com/owncloud/ios-app/pull/1225)

Added Quick Access item "Recents", which was missing in version 12.0.1

https://github.com/owncloud/ios-app/pull/1225

* Bugfix - Attach files from third-party apps: [#1228](https://github.com/owncloud/ios-app/pull/1228)

Attaching files in third-party apps via file provider were not possible, if file was not
downloaded.

https://github.com/owncloud/ios-app/pull/1228

Changelog for ownCloud iOS Client [12.0.1] (2023-06-15)
=======================================
The following sections list the changes in ownCloud iOS Client 12.0.1 relevant to
Expand Down
5 changes: 5 additions & 0 deletions changelog/12.0.2_2023-06-23/1219
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Unable to authenticate using OpenID Connect

It was not able to authenticate using OpenID Connect

https://github.com/owncloud/ios-app/issues/1219
5 changes: 5 additions & 0 deletions changelog/12.0.2_2023-06-23/1223
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Files.app

Solves "Content unavailable" in Files.app

https://github.com/owncloud/ios-app/pull/1223
5 changes: 5 additions & 0 deletions changelog/12.0.2_2023-06-23/1225
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Recent files view

Added Quick Access item "Recents", which was missing in version 12.0.1

https://github.com/owncloud/ios-app/pull/1225
5 changes: 5 additions & 0 deletions changelog/12.0.2_2023-06-23/1228
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Attach files from third-party apps

Attaching files in third-party apps via file provider were not possible, if file was not downloaded.

https://github.com/owncloud/ios-app/pull/1228
8 changes: 6 additions & 2 deletions fastlane/metadata-emm/en-US/release_notes.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
• Bug Fixes
Fixed keyboard, media streaming, full screen mode, offline indicator, duplicated sharing option, and UI issues.
Bug Fixes

• Added missing Recents Group
• Unable to authenticate using OpenID Connect
• Attach files from third-party apps
• Solves "Content unavailable" in Files.app

8 changes: 6 additions & 2 deletions fastlane/metadata-owncloud-online/en-US/release_notes.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
• Bug Fixes
Fixed keyboard, media streaming, full screen mode, offline indicator, duplicated sharing option, and UI issues.
Bug Fixes

• Added missing Recents Group
• Unable to authenticate using OpenID Connect
• Attach files from third-party apps
• Solves "Content unavailable" in Files.app

8 changes: 6 additions & 2 deletions fastlane/metadata/en-US/release_notes.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
• Bug Fixes
Fixed keyboard, media streaming, full screen mode, offline indicator, duplicated sharing option, and UI issues.
Bug Fixes

• Added missing Recents Group
• Unable to authenticate using OpenID Connect
• Attach files from third-party apps
• Solves "Content unavailable" in Files.app

15 changes: 14 additions & 1 deletion ownCloud File Provider/FileProviderExtensionThumbnailRequest.m
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,20 @@ - (void)requestNextThumbnail

if ((core = self.extension.core) != nil)
{
[core retrieveItemFromDatabaseForLocalID:(OCLocalID)itemIdentifier completionHandler:^(NSError *error, OCSyncAnchor syncAnchor, OCItem *itemFromDatabase) {
OCLocalID localID = (OCLocalID)itemIdentifier;

// Translate item identifiers
OCVaultLocation *location;

if ((location = [[OCVaultLocation alloc] initWithVFSItemID:itemIdentifier]) != nil)
{
if (location.localID != nil)
{
localID = location.localID;
}
}

[core retrieveItemFromDatabaseForLocalID:localID completionHandler:^(NSError *error, OCSyncAnchor syncAnchor, OCItem *itemFromDatabase) {
OCLogDebug(@"Retrieving %ld: %@", self.cursorPosition-1, itemFromDatabase.name);

OCResourceManager *resourceManager = core.vault.resourceManager;
Expand Down
8 changes: 4 additions & 4 deletions ownCloud.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -5137,8 +5137,8 @@
APP_BUILD_FLAGS = "$(inherited)";
APP_BUILD_FLAGS_SWIFT = "$(APP_BUILD_FLAGS)";
APP_PRODUCT_NAME = ownCloud;
APP_SHORT_VERSION = 12.0.1;
APP_VERSION = 268;
APP_SHORT_VERSION = 12.0.2;
APP_VERSION = 270;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_ANALYZER_NONNULL = YES;
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
Expand Down Expand Up @@ -5207,8 +5207,8 @@
APP_BUILD_FLAGS = "$(inherited)";
APP_BUILD_FLAGS_SWIFT = "$(APP_BUILD_FLAGS)";
APP_PRODUCT_NAME = ownCloud;
APP_SHORT_VERSION = 12.0.1;
APP_VERSION = 268;
APP_SHORT_VERSION = 12.0.2;
APP_VERSION = 270;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_ANALYZER_NONNULL = YES;
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
Expand Down
47 changes: 47 additions & 0 deletions ownCloud/Release Notes/ReleaseNotes.plist
Original file line number Diff line number Diff line change
Expand Up @@ -1724,6 +1724,53 @@ Added an optional "Wait for completion" option to the "Save File&
</dict>
</array>
</dict>
<dict>
<key>Version</key>
<string>12.0.2</string>
<key>ReleaseNotes</key>
<array>
<dict>
<key>Title</key>
<string>Bug Fixes</string>
<key>Subtitle</key>
<string>Added missing Recents Group</string>
<key>Type</key>
<string>Fix</string>
<key>ImageName</key>
<string>wrench</string>
</dict>
<dict>
<key>Title</key>
<string>Bug Fixes</string>
<key>Subtitle</key>
<string>Unable to authenticate using OpenID Connect</string>
<key>Type</key>
<string>Fix</string>
<key>ImageName</key>
<string>wrench</string>
</dict>
<dict>
<key>Title</key>
<string>Bug Fixes</string>
<key>Subtitle</key>
<string>Attach files from third-party apps</string>
<key>Type</key>
<string>Fix</string>
<key>ImageName</key>
<string>wrench</string>
</dict>
<dict>
<key>Title</key>
<string>Bug Fixes</string>
<key>Subtitle</key>
<string>Solves &quot;Content unavailable&quot; in Files.app</string>
<key>Type</key>
<string>Fix</string>
<key>ImageName</key>
<string>wrench</string>
</dict>
</array>
</dict>
</array>
</dict>
</plist>
4 changes: 4 additions & 0 deletions ownCloudAppFramework/Resources/de.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
"keyword_week" = "woche";
"keyword_month" = "monat";
"keyword_year" = "jahr";
"keyword_recent" = "kürzlich";
"keyword_d" = "t"; /* short-form for "day" */
"keyword_w" = "w"; /* short-form for "week" */
"keyword_m" = "m"; /* short-form for "month" */
Expand Down Expand Up @@ -132,3 +133,6 @@
"This year" = "Dieses Jahr";
"Since last year" = "Seit letztem Jahr";
"Last %d years" = "Letzte %d Jahre";

"Recently used" = "Kürzlich verwendet";
"Not recently used" = "Nicht kürzlich verwendet";
5 changes: 5 additions & 0 deletions ownCloudAppFramework/Resources/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
"keyword_week" = "week";
"keyword_month" = "month";
"keyword_year" = "year";
"keyword_recent" = "recent";
"keyword_d" = "d"; /* short-form for "day" */
"keyword_w" = "w"; /* short-form for "week" */
"keyword_m" = "m"; /* short-form for "month" */
Expand Down Expand Up @@ -132,3 +133,7 @@
"This year" = "This year";
"Since last year" = "Since last year";
"Last %d years" = "Last %d years";

"Recently used" = "Recently used";
"Not recently used" = "Not recently used";

Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ + (nullable NSString *)normalizeKeyword:(NSString *)keyword
TranslateKeyword(@"week"),
TranslateKeyword(@"month"),
TranslateKeyword(@"year"),
TranslateKeyword(@"recent"),

// Modifier keywords
TranslateKeyword(@"type"),
Expand Down Expand Up @@ -338,6 +339,10 @@ + (instancetype)forSearchSegment:(NSString *)segmentString
{
return ([[OCQueryCondition negating:negateCondition condition:[OCQueryCondition where:OCItemPropertyNameLastModified isGreaterThan:[NSDate startOfRelativeYear:0]]] withSymbolName:@"calendar" localizedDescription:(negateCondition ? OCLocalizedViaLocalizationBundle(@"Before this year") : OCLocalizedViaLocalizationBundle(@"This year")) searchSegment:searchSegment]);
}
else if ([keyword isEqual:@"recent"])
{
return ([[OCQueryCondition negating:negateCondition condition:[OCQueryCondition where:OCItemPropertyNameLastUsed isGreaterThan:[NSCalendar.currentCalendar dateByAddingUnit:NSCalendarUnitWeekOfYear value:-1 toDate:NSDate.date options:0]]] withSymbolName:@"clock.arrow.circlepath" localizedDescription:(negateCondition ? OCLocalizedViaLocalizationBundle(@"Not recently used") : OCLocalizedViaLocalizationBundle(@"Recently used")) searchSegment:searchSegment]);
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ public class AccountController: NSObject, OCDataItem, OCDataItemVersioning, Acco
case searchImages
case searchVideos
case searchAudios
case recents

case activity
}
Expand Down Expand Up @@ -404,6 +405,14 @@ public class AccountController: NSObject, OCDataItem, OCDataItemVersioning, Acco
if configuration.showQuickAccess {
var quickAccessItems: [OCDataItem & OCDataItemVersioning] = []

// Recents
if specialItems[.recents] == nil {
specialItems[.recents] = OCSavedSearch(scope: .account, location: nil, name: "Recents".localized, isTemplate: false, searchTerm: ":recent :file").withCustomIcon(name: "clock.arrow.circlepath").useNameAsTitle(true)
}
if let sideBarItem = specialItems[.recents] {
quickAccessItems.append(sideBarItem)
}

// Favorites
if bookmark?.hasCapability(.favorites) == true {
if specialItems[.favoriteItems] == nil {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ class ItemSearchSuggestionsViewController: UIViewController, SearchElementUpdati
OCQueryCondition.fromSearchTerm(":audio")!
]),
Category(name: "Date".localized, selectionBehaviour: Category.mutuallyExclusiveSelectionBehaviour, options: [
OCQueryCondition.fromSearchTerm(":recent")!,
OCQueryCondition.fromSearchTerm(":today")!,
OCQueryCondition.fromSearchTerm(":week")!,
OCQueryCondition.fromSearchTerm(":month")!,
Expand Down