-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[milestone/12.3] Milestone 12.3 #1356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3 tasks
After merge, progress on 12.3 is tracked in: |
- INIFile+URLFile: simple extension for quickly parsing and composing .url files - URLDisplayViewController: stub implementation to handle .url files
…ng shortcut URL - CreateURLShortcutAction: new action to create a URL shortcut in a folder - design and add "text-uri-list" icon
… open files from file lists, overriding viewers if needed - OCItem+Interactions: add support for `.directOpen` actions - INIFile+ShortcutResolution: implement support for shortcuts to other items on the same server - ShortcutFileDisplayViewController: implement support for shortcuts to other items on the same server, including an item preview - add new action OpenShortcutFileAction - hooks into the `.directOpen` location - uses INIFile+ShortcutResolution to open the contained link or jump to the targeted location - asks users before opening links - rename files for better distinctibility: - URLDisplayViewController -> ShortcutFileDisplayViewController - CreateURLShortcutAction -> CreateShortcutFileAction - OCItem+UniversalItemListCellContentProvider: fix warning
- CreateShortcutFileAction: break out creation functionality into its own view controller - CreateShortcutFileViewController: - dedicated view controller for creating shortcuts - allows picking files and folders for shortcuts to point to and presents an embedded preview for them - improved error handling - INIFile: fix formatting bug that could accidentally leak memory into the .url file - ClientLocationPicker: add ability to allow picking files via new .allowFileSelection property
…targeting unavailable/detached drives and removes the respective policies - adapt app code to SDK API changes
- improved error reporting for when the target of a shortcut can't be accessed / found - simplified and generalized prompt for opening the URL a shortcut points to
…ShortcutResolution: add MDM option to allow all shortcuts, only URL shortcuts, only item shortcuts or no shortcuts
…root, the name for the shortcut was not derived correctly
- Localizable.strings: re-add strings auto-removed by git during rebase
- ios-sdk: use branch fix/warnings that fixes OpenSSL warnings - replace associated keys using structs or strings with static malloc results as suggested by Apple Engineer Quinn (https://forums.swift.org/t/handling-the-new-forming-unsaferawpointer-warning/65523/7) - remove unneeded/unused overrides - reformat spacing in parts of the code and remove superfluous spaces to remove SwiftLint warnings - replace calls to CLLocationManager.authorizationStatus() with CLLocationManager.authorizationStatus - remove deprecated OpenSSL ERR_load_* calls, since OpenSSL loads these automatically (https://www.openssl.org/docs/man3.3/man7/migration_guide.html) - LAContext+Extension: add cases for Optic ID - remove unused variables and calls - remove unused, non-existent "gear.png" image from asset catalog
felix-schwarz
force-pushed
the
milestone/12.3
branch
from
May 27, 2024 12:57
62ac8dc
to
532b6ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Target PR for all changes in milestone 12.3. Already merged:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: