-
Notifications
You must be signed in to change notification settings - Fork 76
Make accounts collapsable and show only important folders #1445
Conversation
By analyzing the blame information on this pull request, we identified @jancborchardt, @DeepDiver1975 and @Gomez to be potential reviewers |
So far it doesn’t seem to collapse anything? Like Trash, Sent, Spam, all custom folders, (and maybe Drafts) should definitely be hidden by default. |
Works on FF and Chromium |
Arrrgh … again seemed to be a caching issue. ;) Works fine, and very nice! :) Instead of clicking the account name to expand it (that should actually open the menu #1446), I would say there should be one more line saying »Show all folders …«. On the bottom, at 50% opacity which triggers the folders. Because that’s more related as the folders are shown below the important ones. Then ideally there should also be a short animation to have some feedback of what’s happening, and the »Show all folders …« thing can change to »Collapse folders …«. |
56a822d
to
ad57ca3
Compare
@jancborchardt thanks a lot for your feedback. I updated the commit according to your suggestions: An animation can be added later, I'll have to think about how to do that properly. |
Nice! The line-height / padding is off a bit, that is between drafts and show all folders there's less space than between the othets. Is it a li as well? If not, should get the same padding values as the lis. |
ad57ca3
to
f38fd93
Compare
Good catch, I fixed the css. No, it's not a li so I had to manually apply margin to align it with the other navigation entries. |
Nice, 👍! |
fixes #677
Suggestions on what folders are to be considered important und should be shown even when the account is collapsed are welcome.
We can think about automatically hiding drafts if there are none, but as long as the client-side is not always up to date with the server state I'd like to not add that enhancement yet and wait until we have solved that cleanly.
@jancborchardt I'm afraid this is very badly discoverable. Any idea how to solve that?