Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ampache: Support authentication using the HTTP header #1140

Closed
paulijar opened this issue Apr 6, 2024 · 1 comment
Closed

Ampache: Support authentication using the HTTP header #1140

paulijar opened this issue Apr 6, 2024 · 1 comment
Labels
6 - Ready for release Fix or feature is ready and will be included in the next release Enhancement

Comments

@paulijar
Copy link
Collaborator

paulijar commented Apr 6, 2024

The recent versions of Ampache support passing the authentication token in a HTTP header instead of using an URL argument or POST data for this: https://ampache.org/api/#http-header-authentication. The forthcoming Ample v3 will use the new authentication mechanism.

It should be investigated if the Music app could support this, too. One potential problem is that the host cloud may intercept the header and do some undesired actions with it.
@paulijar paulijar mentioned this issue Apr 6, 2024
Closed
paulijar added a commit that referenced this issue Apr 19, 2024
@paulijar
Ampache: Support authentication using the bearer token header
172f7a8 
Instead of sending the session token as an URL argument, it's now
alternatively possible to deliver it using the HTTP header
`Authorization` with the content "Bearer <token>".

This required using the PHP function getallheaders() which is available
for all HTTP servers starting from PHP 7.3 but only for Apache on older
PHP versions.

refs #1140
@paulijar paulijar added the 6 - Ready for release Fix or feature is ready and will be included in the next release label Apr 19, 2024
@paulijar
Copy link
Collaborator Author

This feature is now released in Music v1.11.0.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6 - Ready for release Fix or feature is ready and will be included in the next release Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulijar