Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] predefine the exclude path when setting it #876

Closed
mmattel opened this issue Aug 6, 2021 · 5 comments
Closed

[FR] predefine the exclude path when setting it #876

mmattel opened this issue Aug 6, 2021 · 5 comments

Comments

@mmattel
Copy link

mmattel commented Aug 6, 2021

When you set the path to your music collection, you define the root path for the audio files.
When defining an exclude path, you get again the full list of mounts.

This FR is about that an exclude path must be inside the collection path and therefore the list of possible selectable paths must not show all mounts but only all folders inside the collection path defined before.

paulijar added a commit that referenced this issue Aug 21, 2021
…ossible

When opening the folder picker UI to set an excluded folder, the dialog is
now opened with the current music library root folder as base path. However,
the filepicker dialog component supports this only on Nextcloud and only
starting from the version NC16. That is, on ownCloud and older versions of
Nextcloud the folder picker UI always start from the user home folder as
before.

refs #876
@paulijar
Copy link
Collaborator

The excluded folder picker UI component has now been set to be opened with the configured music library path as the initial path. This change will be included in the Music v1.3.0 once that's published.

The limitation is that this is possible only on Nextcloud and only with versions 16 and later. On ownCloud and older versions of Nextcloud, the filepicker dialog provided by the core does not support setting the initial path. On those environments, the excluded folder picking will work just like before.

@mmattel
Copy link
Author

mmattel commented Aug 21, 2021

Thanks for the fix 😄 , but unhappy regarding ownCloud 😢

@paulijar
Copy link
Collaborator

The newly released Music v1.3.1 now contains the change mentioned above.

@etyrnal
Copy link

etyrnal commented Sep 1, 2021

this change feels like it forces Music to be stuck in the paradigm of only having a single source folder for music files. With External Storages enabled, there can be multiple source folders of music, but the Music app makes it impossible to address multiple sources. But for some reason we can exclude any number of folders -- yet we cannot address multiple music sources.

@paulijar
Copy link
Collaborator

paulijar commented Sep 1, 2021

@etyrnal No, not really. If we at some point add the support for defining multiple library folders, then the feature implemented here just needs a minor modification: In case the user actually has configured multiple paths, then open the exclude folder from the user root folder (like before).

As of today, the application already can handle library consisting of multiple source folders, some of which may be external storages or shared folders: Just select the root folder as the library path, and exclude anything you don't want to be included. Of course this may be cumbersome and awkward in some cases, but not impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants