Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change summary, description and category, add website, bugs, repository #78

Merged
merged 3 commits into from
Aug 17, 2017

Conversation

pmaier1
Copy link
Contributor

@pmaier1 pmaier1 commented Aug 14, 2017

Documentation is missing as we don't have anything yet.
Screenshot is still empty. Following are two screenshots that still need to be checked regarding dimensions. Please check and upload @hurradieweltgehtunter, then we can insert here and merge. Thanks!

Btw. I can't make @tobiherr a reviewer here :/

oauth_1

oauth_2

@pmaier1 pmaier1 added this to the QA milestone Aug 14, 2017
@CLAassistant
Copy link

CLAassistant commented Aug 14, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 14, 2017

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #78   +/-   ##
=========================================
  Coverage     83.96%   83.96%           
  Complexity      179      179           
=========================================
  Files            20       20           
  Lines           636      636           
=========================================
  Hits            534      534           
  Misses          102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca8b8fc...9edcb35. Read the comment docs.

appinfo/info.xml Outdated
<website>https://github.com/owncloud/oauth2</website>
<bugs>https://github.com/owncloud/oauth2/issues</bugs>
<repository type="git">https://github.com/owncloud/oauth2.git</repository>
<screenshot></screenshot>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no screenshot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read top post :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sry :)

@hurradieweltgehtunter
Copy link

added screenshot. Description, summary etc. fine with me

@DeepDiver1975 DeepDiver1975 merged commit 84d178a into master Aug 17, 2017
@DeepDiver1975 DeepDiver1975 deleted the pmaier1-patch-1 branch August 17, 2017 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants