Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add web url config options #340

Merged
merged 4 commits into from
Jul 19, 2023
Merged

add web url config options #340

merged 4 commits into from
Jul 19, 2023

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jun 28, 2023

Description

expose more web url config options

Related Issue

Motivation and Context

How Has This Been Tested?

set this values:

services:
  web:
    config:
      postLogoutRedirectURI: https://ocis.kube.owncloud.test/thisisacustompostlogouturi
      accessDeniedHelpURL: https://foo.bar/accessdenied
      imprintURL: https://foo.bar/imprint
      privacyURL: https://foo.bar/privacy

Screenshots (if appropriate):

image

image

(just go to https://ocis.kube.owncloud.test/access-denied and you'll see the "More" / "Mehr anzeigen" only if accessDeniedHelpURL is set)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@wkloucek wkloucek marked this pull request as ready for review July 19, 2023 14:04
@wkloucek wkloucek requested a review from d7oc July 19, 2023 14:04
Copy link
Contributor

@d7oc d7oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside the comment about the description format.

charts/ocis/values.yaml Outdated Show resolved Hide resolved
Co-authored-by: Dennis Sieben <102977884+d7oc@users.noreply.github.com>
@wkloucek wkloucek merged commit 1c6c1c0 into master Jul 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the web-url-config-options branch July 19, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Web post logout URI Support Web "logged out url" Support Web imprint and privacy url
2 participants