add nats deployment example #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmattel
reviewed
Jul 5, 2023
Comment on lines
+1
to
+11
| # oCIS with NATS deployment example | ||
|
|
||
| ## Introduction | ||
|
|
||
| This example shows how to deploy NATS with NATS as message bus and store. | ||
| It will deploy an oCIS instance and NATS, preconfigured to work together. | ||
|
|
||
| ***Note***: This example is not intended for production use. It is intended to get a working oCIS | ||
| with NATS running in Kubernetes as quickly as possible. It is not hardened in any way. | ||
|
|
||
| ## Getting started |
There was a problem hiding this comment.
Suggested change
| # oCIS with NATS deployment example | |
| ## Introduction | |
| This example shows how to deploy NATS with NATS as message bus and store. | |
| It will deploy an oCIS instance and NATS, preconfigured to work together. | |
| ***Note***: This example is not intended for production use. It is intended to get a working oCIS | |
| with NATS running in Kubernetes as quickly as possible. It is not hardened in any way. | |
| ## Getting started | |
| # oCIS with NATS Deployment Example | |
| ## Introduction | |
| This example shows how to deploy NATS with NATS as message bus and store. | |
| It will deploy an oCIS instance and NATS, preconfigured to work together. | |
| ***Note***: This example is not intended for production use and is not hardened in any way. It is intended as template to get a working oCIS instance running with NATS in Kubernetes as quickly as possible. | |
| ## Getting started |
There was a problem hiding this comment.
I will do this in a subsequent PR, because this feedback can be applied to all deployment examples. Tracker ticket, so it doesn't get lost: #354
mmattel
reviewed
Jul 5, 2023
Comment on lines
+21
to
+28
| ### End result | ||
|
|
||
| After following the steps in this guide, you should be able to access the following endpoint, you | ||
| may want to add these to your `/etc/hosts` file pointing to your ingress controller IP: | ||
|
|
||
| - https://ocis.kube.owncloud.test | ||
|
|
||
| Note that if you want to use your own hostname and domain, you will have to change the `externalDomain` value. |
There was a problem hiding this comment.
Suggested change
| ### End result | |
| After following the steps in this guide, you should be able to access the following endpoint, you | |
| may want to add these to your `/etc/hosts` file pointing to your ingress controller IP: | |
| - https://ocis.kube.owncloud.test | |
| Note that if you want to use your own hostname and domain, you will have to change the `externalDomain` value. | |
| ### Final Result | |
| After following the steps in this guide, you should be able to access the following endpoint which you may want to add to your `/etc/hosts` file pointing to your ingress controller IP: | |
| - https://ocis.kube.owncloud.test | |
| Note that if you want to use your own hostname and domain, you will have to change the `externalDomain` value. |
...should be able to access the following endpoint...
but where is the endpoint mentioned?
There was a problem hiding this comment.
The endpoint is the the url down below, so https://ocis.kube.owncloud.test.
There was a problem hiding this comment.
THX, will adapt the suggestion - done.
There was a problem hiding this comment.
I will do this in a subsequent PR, because this feedback can be applied to all deployment examples. Tracker ticket, so it doesn't get lost: #354
Closed
d7oc
approved these changes
Jul 5, 2023
Comment on lines
+21
to
+28
| ### End result | ||
|
|
||
| After following the steps in this guide, you should be able to access the following endpoint, you | ||
| may want to add these to your `/etc/hosts` file pointing to your ingress controller IP: | ||
|
|
||
| - https://ocis.kube.owncloud.test | ||
|
|
||
| Note that if you want to use your own hostname and domain, you will have to change the `externalDomain` value. |
There was a problem hiding this comment.
The endpoint is the the url down below, so https://ocis.kube.owncloud.test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a deployment example on how to deploy oCIS with an external NATS
NOTE: it's currently affected by #322
Related Issue
Motivation and Context
have a working / development / debug example
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
make docs) and committed