Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] add test to download files and folders as archive by ocm user #10740

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[tests-only][full-ci] add test to download files and folders as archive by ocm user #10740

merged 1 commit into from
Dec 23, 2024

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Dec 6, 2024 •
edited
Loading

Description

This PR adds test to download files and folders as archive by OCM user

Scenario: federated user downloads shared resources as an archive

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-download-archive branch 2 times, most recently from 1864229 to 1e950ed Compare December 6, 2024 04:20
@prashant-gurung899 prashant-gurung899 self-assigned this Dec 6, 2024
@prashant-gurung899 prashant-gurung899 mentioned this pull request Dec 6, 2024
Closed
37 tasks
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-download-archive branch 9 times, most recently from 3a7bb60 to 9015416 Compare December 10, 2024 04:04
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review December 10, 2024 04:47
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-download-archive branch 4 times, most recently from bcf5157 to b2eca08 Compare December 11, 2024 06:21
PrajwolAmatya
PrajwolAmatya reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-download-archive branch from b2eca08 to f3fb844 Compare December 13, 2024 06:02
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-download-archive branch 3 times, most recently from fb79455 to 328873f Compare December 16, 2024 04:06
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-download-archive branch 4 times, most recently from 91a814c to 3fa547a Compare December 17, 2024 11:46
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-download-archive branch 2 times, most recently from 3c2bf64 to 9199334 Compare December 18, 2024 06:13
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-download-archive branch 2 times, most recently from 9229cf4 to 8e2eb74 Compare December 19, 2024 05:05
@prashant-gurung899
add test to download files and folders as archive
367f551 
Signed-off-by: prashant-gurung899 <prasantgrg777@gmail.com>
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-download-archive branch from 8e2eb74 to 367f551 Compare December 23, 2024 05:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

amrita-shrestha
amrita-shrestha approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prashant-gurung899 prashant-gurung899 merged commit a5f3ce3 into master Dec 23, 2024
4 checks passed
@prashant-gurung899 prashant-gurung899 deleted the tests-ocm-download-archive branch December 23, 2024 11:51
ownclouders pushed a commit that referenced this pull request Dec 23, 2024
@prashant-gurung899
Merge pull request #10740 from owncloud/tests-ocm-download-archive
eaecf5d 
[tests-only][full-ci] add test to download files and folders as archive by ocm user
ownclouders pushed a commit that referenced this pull request Dec 24, 2024
@prashant-gurung899
Merge pull request #10740 from owncloud/tests-ocm-download-archive
2d1858c 
[tests-only][full-ci] add test to download files and folders as archive by ocm user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@prashant-gurung899 prashant-gurung899

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prashant-gurung899 @saw-jan @amrita-shrestha @PrajwolAmatya