Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Reva and Go #1833

Merged
merged 7 commits into from
Mar 24, 2021
Merged

update Reva and Go #1833

merged 7 commits into from
Mar 24, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Mar 22, 2021 •
edited
Loading

Description

Update Reva. Update to Go 1.16 was needed, see also cs3org/reva#1556. Therefore switching to owncloudci/golang:1.16 (fixes #1840).

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Mar 22, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek force-pushed the update_reva branch 2 times, most recently from 86a1083 to 70ebcd6 Compare March 22, 2021 12:41
@wkloucek wkloucek changed the title update reva update Reva and Go Mar 23, 2021
@wkloucek wkloucek marked this pull request as ready for review March 23, 2021 14:26
@wkloucek wkloucek requested a review from refs March 23, 2021 14:26
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/4259/77/3
The docker-arm pipeline fails in the "generate go" step.
make: bash: Operation not permitted

I will restart CI - let's see if this is a real problem with the webhippie/golang:1.16 docker image for ARM

This was referenced Mar 24, 2021
Closed
Closed
individual-it
individual-it approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more tests pass than before, so it must be a good thing 🚀

just something weird happens on ARM

@phil-davis
Copy link
Contributor

just something weird happens on ARM

I raised issue #1840 - the ARM fail is happening on all PRs

@wkloucek wkloucek force-pushed the update_reva branch 2 times, most recently from e254a16 to 9699e3c Compare March 24, 2021 09:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit d18b6d7 into master Mar 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the update_reva branch March 24, 2021 12:23
ownclouders pushed a commit that referenced this pull request Mar 24, 2021
@wkloucek
commit d18b6d7
f4bd20b 
Merge: 39937ce 1314aac
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Wed Mar 24 13:23:33 2021 +0100

    Merge pull request #1833 from owncloud/update_reva

    update Reva and Go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

@micbar micbar Awaiting requested review from micbar

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@refs refs Awaiting requested review from refs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wkloucek @phil-davis @individual-it