Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set go version to 1.22.0 #8732

Merged
merged 1 commit into from
Mar 28, 2024
Merged

set go version to 1.22.0 #8732

merged 1 commit into from
Mar 28, 2024

Conversation

individual-it
Copy link
Member

Description

Set go version including the patch release to avoid an unfixed bug in go.

Motivation and Context

After cleaning my go cache

go clean -modcache
go clean -cache

I couldn't build ocis anymore, make generate would stop with ERR unable to parse packages error="err: exit status 1: stderr: go: downloading go1.22 (linux/amd64)\ngo: download go1.22 for linux/amd64: toolchain not available\n" dry-run=false version=v2.40.2

setting the version in go.mod to 1.22.0 fixes the problem.
alternative workaround GOTOOLCHAIN=go1.22.0 make generate

How Has This Been Tested?

  • run make generate locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Mar 26, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot reproduce the issue locally. But since the change does no harm and fixes the issue for you, I'm fine with merging it 👍

@individual-it individual-it merged commit 7f42738 into master Mar 28, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the goVersionWithPatch branch March 28, 2024 10:46
ownclouders pushed a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants