refactor: switch back to upstream uppy

owncloud · Dec 30, 2024 · e1828e7 · e1828e7
1 parent 26460ea
commit e1828e7
Show file tree

Hide file tree

Showing 16 changed files with 331 additions and 333 deletions.
diff --git a/package.json b/package.json
@@ -96,23 +96,6 @@
     "node": "22.12.0"
   },
   "pnpm": {
-    "overrides": {
-      "@uppy/companion-client": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-companion-client.tgz",
-      "@uppy/core": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-core.tgz",
-      "@uppy/dashboard": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-dashboard.tgz",
-      "@uppy/drop-target": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-drop-target.tgz",
-      "@uppy/google-drive": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-google-drive.tgz",
-      "@uppy/informer": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-informer.tgz",
-      "@uppy/onedrive": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-onedrive.tgz",
-      "@uppy/provider-views": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-provider-views.tgz",
-      "@uppy/status-bar": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-status-bar.tgz",
-      "@uppy/store-default": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-store-default.tgz",
-      "@uppy/thumbnail-generator": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-thumbnail-generator.tgz",
-      "@uppy/tus": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-tus.tgz",
-      "@uppy/utils": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-utils.tgz",
-      "@uppy/webdav": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-webdav.tgz",
-      "@uppy/xhr-upload": "https://github.com/owncloud/uppy/releases/download/v3.12.13-owncloud/uppy-xhr-upload.tgz"
-    },
     "packageExtensions": {
       "@toast-ui/editor": {
         "dependencies": {

diff --git a/packages/web-app-files/package.json b/packages/web-app-files/package.json
@@ -11,7 +11,7 @@
     "@ownclouders/design-system": "workspace:^",
     "@ownclouders/web-client": "workspace:*",
     "@ownclouders/web-pkg": "workspace:*",
-    "@uppy/core": "^3.3.0 || ^4.0.0",
+    "@uppy/core": "4.3.1",
     "@vueuse/core": "^11.0.0 || ^12.0.0",
     "axios": "1.7.9",
     "email-validator": "^2.0.4",

diff --git a/packages/web-app-files/src/HandleUpload.ts b/packages/web-app-files/src/HandleUpload.ts
@@ -1,4 +1,4 @@
-import Uppy, { BasePlugin, UppyFile } from '@uppy/core'
+import Uppy, { BasePlugin } from '@uppy/core'
 import { basename, dirname, join } from 'path'
 import { v4 as uuidV4 } from 'uuid'
 import { Language } from 'vue3-gettext'
@@ -13,11 +13,15 @@ import {
   SpacesStore,
   UserStore,
   locationPublicLink,
-  formatFileSize
+  formatFileSize,
+  OcUppyFile,
+  OcUppyMeta,
+  OcUppyBody
 } from '@ownclouders/web-pkg'
-import { locationSpacesGeneric, UppyService, UppyResource } from '@ownclouders/web-pkg'
+import { locationSpacesGeneric, UppyService } from '@ownclouders/web-pkg'
 import { isPersonalSpaceResource, isShareSpaceResource } from '@ownclouders/web-client'
 import { ClientService, queryItemAsString } from '@ownclouders/web-pkg'
+import { PluginOpts } from '@uppy/core/lib/BasePlugin'
 
 export interface HandleUploadOptions {
   clientService: ClientService
@@ -44,7 +48,7 @@ export interface HandleUploadOptions {
  * 4. create directory tree if needed
  * 5. start upload
  */
-export class HandleUpload extends BasePlugin {
+export class HandleUpload extends BasePlugin<PluginOpts, OcUppyMeta, OcUppyBody> {
   clientService: ClientService
   language: Language
   route: Ref<RouteLocationNormalizedLoaded>
@@ -58,7 +62,7 @@ export class HandleUpload extends BasePlugin {
   directoryTreeCreateEnabled: boolean
   conflictHandlingEnabled: boolean
 
-  constructor(uppy: Uppy, opts: HandleUploadOptions) {
+  constructor(uppy: Uppy<OcUppyMeta, OcUppyBody>, opts: HandleUploadOptions) {
     super(uppy, opts)
     this.id = opts.id || 'HandleUpload'
     this.type = 'modifier'
@@ -81,7 +85,7 @@ export class HandleUpload extends BasePlugin {
     this.handleUpload = this.handleUpload.bind(this)
   }
 
-  removeFilesFromUpload(filesToUpload: UppyResource[]) {
+  removeFilesFromUpload(filesToUpload: OcUppyFile[]) {
     for (const file of filesToUpload) {
       this.uppy.removeFile(file.id)
     }
@@ -104,8 +108,8 @@ export class HandleUpload extends BasePlugin {
   /**
    * Converts the input files type UppyResources and updates the uppy upload queue
    */
-  prepareFiles(files: UppyFile[], uploadFolder: Resource): UppyResource[] {
-    const filesToUpload: Record<string, UppyResource> = {}
+  prepareFiles(files: OcUppyFile[], uploadFolder: Resource): OcUppyFile[] {
+    const filesToUpload: Record<string, OcUppyFile> = {}
 
     if (!this.resourcesStore.currentFolder && unref(this.route)?.params?.token) {
       // public file drop
@@ -127,7 +131,7 @@ export class HandleUpload extends BasePlugin {
           uploadId: uuidV4()
         }
 
-        filesToUpload[file.id] = file as unknown as UppyResource
+        filesToUpload[file.id] = file
       }
       this.uppy.setState({ files: { ...this.uppy.getState().files, ...filesToUpload } })
       return Object.values(filesToUpload)
@@ -138,7 +142,7 @@ export class HandleUpload extends BasePlugin {
     const topLevelFolderIds: Record<string, string> = {}
 
     for (const file of files) {
-      const relativeFilePath = (file.meta.relativePath || file.meta.webkitRelativePath) as string
+      const relativeFilePath = file.meta.relativePath
       // Directory without filename
       const directory =
         !relativeFilePath || dirname(relativeFilePath) === '.' ? '' : dirname(relativeFilePath)
@@ -166,7 +170,7 @@ export class HandleUpload extends BasePlugin {
         ...file.meta,
         // file data
         name: file.name,
-        mtime: file.data.lastModified / 1000,
+        mtime: (file.data as File).lastModified / 1000,
         // current path & space
         spaceId: unref(this.space).id,
         spaceName: unref(this.space).name,
@@ -186,27 +190,25 @@ export class HandleUpload extends BasePlugin {
         routeShareId: queryItemAsString(query?.shareId) || ''
       }
 
-      filesToUpload[file.id] = file as unknown as UppyResource
+      filesToUpload[file.id] = file
     }
 
     this.uppy.setState({ files: { ...this.uppy.getState().files, ...filesToUpload } })
     return Object.values(filesToUpload)
   }
 
-  checkQuotaExceeded(filesToUpload: UppyResource[]): boolean {
+  checkQuotaExceeded(filesToUpload: OcUppyFile[]): boolean {
     let quotaExceeded = false
 
-    const uploadSizeSpaceMapping = filesToUpload.reduce((acc, uppyResource) => {
+    const uploadSizeSpaceMapping = filesToUpload.reduce((acc, uppyFile) => {
       let targetUploadSpace: SpaceResource
 
-      if (uppyResource.meta.routeName === locationPublicLink.name) {
+      if (uppyFile.meta.routeName === locationPublicLink.name) {
         return acc
       }
 
-      if (uppyResource.meta.routeName === locationSpacesGeneric.name) {
-        targetUploadSpace = this.spacesStore.spaces.find(
-          ({ id }) => id === uppyResource.meta.spaceId
-        )
+      if (uppyFile.meta.routeName === locationSpacesGeneric.name) {
+        targetUploadSpace = this.spacesStore.spaces.find(({ id }) => id === uppyFile.meta.spaceId)
       }
 
       if (
@@ -219,7 +221,7 @@ export class HandleUpload extends BasePlugin {
       }
 
       const existingFile = this.resourcesStore.resources.find(
-        (c) => !uppyResource.meta.relativeFolder && c.name === uppyResource.name
+        (c) => !uppyFile.meta.relativeFolder && c.name === uppyFile.name
       )
       const existingFileSize = existingFile ? Number(existingFile.size) : 0
 
@@ -230,12 +232,12 @@ export class HandleUpload extends BasePlugin {
       if (!matchingMappingRecord) {
         acc.push({
           space: targetUploadSpace,
-          uploadSize: uppyResource.data.size - existingFileSize
+          uploadSize: uppyFile.data.size - existingFileSize
         })
         return acc
       }
 
-      matchingMappingRecord.uploadSize = uppyResource.data.size - existingFileSize
+      matchingMappingRecord.uploadSize = uppyFile.data.size - existingFileSize
 
       return acc
     }, [])
@@ -274,9 +276,9 @@ export class HandleUpload extends BasePlugin {
    * Creates the directory tree and removes files of failed directories from the upload queue.
    */
   async createDirectoryTree(
-    filesToUpload: UppyResource[],
+    filesToUpload: OcUppyFile[],
     uploadFolder: Resource
-  ): Promise<UppyResource[]> {
+  ): Promise<OcUppyFile[]> {
     const { webdav } = this.clientService
     const space = unref(this.space)
     const { id: currentFolderId, path: currentFolderPath } = uploadFolder
@@ -307,7 +309,7 @@ export class HandleUpload extends BasePlugin {
         const uploadId = !isRoot ? uuidV4() : topLevelIds[path]
         const relativeFolder = dirname(path) === '/' ? '' : dirname(path)
 
-        const uppyResource = {
+        const uppyFile = {
           id: uuidV4(),
           name: basename(path),
           isFolder: true,
@@ -332,22 +334,22 @@ export class HandleUpload extends BasePlugin {
           return
         }
 
-        this.uppyService.publish('addedForUpload', [uppyResource])
+        this.uppyService.publish('addedForUpload', [uppyFile])
 
         try {
           const folder = await webdav.createFolder(space, {
             path: urlJoin(currentFolderPath, path),
             fetchFolder: isRoot
           })
           this.uppyService.publish('uploadSuccess', {
-            ...uppyResource,
-            meta: { ...uppyResource.meta, fileId: folder?.fileId }
+            ...uppyFile,
+            meta: { ...uppyFile.meta, fileId: folder?.fileId }
           })
         } catch (error) {
           if (error.statusCode !== 405) {
             console.error(error)
             failedFolders.push(path)
-            this.uppyService.publish('uploadError', { file: uppyResource, error })
+            this.uppyService.publish('uploadError', { file: uppyFile, error })
           }
         }
       }
@@ -380,7 +382,7 @@ export class HandleUpload extends BasePlugin {
    * The handler that prepares all files to be uploaded and goes through all necessary steps.
    * Eventually triggers to upload in Uppy.
    */
-  async handleUpload(files: UppyFile[]) {
+  async handleUpload(files: OcUppyFile[]) {
     if (!files.length) {
       return
     }
@@ -415,7 +417,7 @@ export class HandleUpload extends BasePlugin {
         }
 
         filesToUpload = result
-        const conflictMap = result.reduce<Record<string, UppyResource>>((acc, file) => {
+        const conflictMap = result.reduce<Record<string, OcUppyFile>>((acc, file) => {
           acc[file.id] = file
           return acc
         }, {})

diff --git a/packages/web-app-files/src/components/AppBar/CreateAndUpload.vue b/packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
@@ -191,6 +191,7 @@ import {
   useFileActionsCreateNewShortcut,
   useMessages,
   useResourcesStore,
+  useRoute,
   useSharesStore,
   useSpacesStore,
   useUserStore
@@ -225,7 +226,6 @@ import {
 } from '@ownclouders/web-client'
 import { useService, useUpload, UppyService, UploadResult } from '@ownclouders/web-pkg'
 import { HandleUpload } from '../../HandleUpload'
-import { useRoute } from 'vue-router'
 import { useGettext } from 'vue3-gettext'
 import { useExtensionRegistry } from '@ownclouders/web-pkg'
 import { Action, ResourceIcon } from '@ownclouders/web-pkg'

diff --git a/packages/web-app-files/src/helpers/resource/actions/upload.ts b/packages/web-app-files/src/helpers/resource/actions/upload.ts
@@ -3,12 +3,12 @@ import { Resource } from '@ownclouders/web-client'
 import { extractExtensionFromFile } from '@ownclouders/web-client'
 import {
   ConflictDialog,
+  OcUppyFile,
   ResolveConflict,
   resolveFileNameDuplicate,
   ResolveStrategy,
   ResourceConflictModal,
   ResourcesStore,
-  UppyResource,
   useModals
 } from '@ownclouders/web-pkg'
 
@@ -59,7 +59,7 @@ export class UploadResourceConflict extends ConflictDialog {
     })
   }
 
-  getConflicts(files: UppyResource[]): ConflictedResource[] {
+  getConflicts(files: OcUppyFile[]): ConflictedResource[] {
     const conflicts: ConflictedResource[] = []
     for (const file of files) {
       const relativeFilePath = file.meta.relativePath
@@ -87,9 +87,9 @@ export class UploadResourceConflict extends ConflictDialog {
   }
 
   async displayOverwriteDialog(
-    files: UppyResource[],
+    files: OcUppyFile[],
     conflicts: ConflictedResource[]
-  ): Promise<UppyResource[]> {
+  ): Promise<OcUppyFile[]> {
     let fileCount = 0
     let folderCount = 0
     const resolvedFileConflicts: { name: string; strategy: ResolveStrategy }[] = []