Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup card on live map loses name after initial refresh #450

Closed
jpmens opened this issue Feb 8, 2024 · 1 comment
Closed

Popup card on live map loses name after initial refresh #450

jpmens opened this issue Feb 8, 2024 · 1 comment

Comments

@jpmens
Copy link
Member

jpmens commented Feb 8, 2024

When a point on the live map (/last) is clicked on, we see the user card with face and name:

jagular181

when the next live location for this user arrives at the map, only the tid is displayed and no longer the name, probably because we haven't stored CARDs in local storage which we likely should.

And while we're at it, the whole styling of the popup could do with quite a bit of refresh.

patthoyts added a commit to patthoyts/recorder that referenced this issue Jun 15, 2024
When processing the most recent location update this gets pushed over the
websocket to update the live map last position. If a card is present it
needs to be added just before this push occurs.
jpmens added a commit that referenced this issue Jun 16, 2024
issue #450: add card data to websocket notifications
@jpmens
Copy link
Member Author

jpmens commented Jun 16, 2024

Closed via #474

@jpmens jpmens closed this as completed Jun 16, 2024
jpmens added a commit that referenced this issue Jul 23, 2024
- FIX: add card data to websocket notifications (#450)
- FIX: Enable building when WITH_TZ=no to disable timezone information (#473)
- FIX: view lastpos response (#471)
- FIX: handle out-of-order location notification in last/ (#472)
- FIX: drastically reduce memory leakage in views (#464)
- FIX: reformat json if it contains newlines/tabs before storing in .rec (#437)
- NEW: cached geo records can be auto-expired by setting OTR_CLEAN_AGE (#447)
- NEW: option -J prints variables in JSON format, for scripting
- NEW: version is printed in -J / -V
- FIX: in http mode friends' data must contain a topic; construct it or retrieve from last if available (#451)
- FIX: crash on non-string event name in _transition messages (#454)
- NEW: Add alt field to GeoJSON points parameters (#456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant