Remove accidental eval #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thank you. |
jpmens
added a commit
that referenced
this pull request
Sep 29, 2022
- FIX: Remove accidental eval (#403) - FIX: Various build fixes (#402) - FIX: now compiles without MQTT (#401) - FIX: read OTR_TOPICS from environment (overrides config); can be overriden by argv - UPD: ocat -v shows compiled-in values, ot-recorder -V runtime ones - FIX: add "OTR_HTTPPREFIX" (verbatim) to tour url if prefix unconfigured (#399) - FIX: Duplicate log entries when running as daemon (#398) - FIX: package build for raspbian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This call constitutes an
evaloperation, which is generally bad practice in JS, and results in errors if you run the page with a strictContent Security Policy.Calling the function by reference does not invoke
eval:)