Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: combined #337

Closed
wants to merge 1 commit into from
Closed

perf: combined #337

wants to merge 1 commit into from

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 11, 2024

No description provided.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 24 lines in your changes missing coverage. Please review.

Project coverage is 96.20%. Comparing base (b00b2b8) to head (22c2e60).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/file_system.rs 64.44% 16 Missing ⚠️
src/cache.rs 91.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   96.94%   96.20%   -0.75%     
==========================================
  Files          11       11              
  Lines        2458     2502      +44     
==========================================
+ Hits         2383     2407      +24     
- Misses         75       95      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Boshen Boshen force-pushed the combined branch 2 times, most recently from e3b6586 to 0fd8633 Compare December 11, 2024 13:47
Copy link

codspeed-hq bot commented Dec 11, 2024

CodSpeed Performance Report

Merging #337 will degrade performances by 17.36%

Comparing combined (22c2e60) with main (b00b2b8)

Summary

❌ 3 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main combined Change
resolver[multi-thread] 465.7 µs 530.3 µs -12.18%
resolver[resolve from symlinks] 53.4 ms 64.6 ms -17.36%
resolver[single-thread] 433.4 µs 491.6 µs -11.84%

@Boshen Boshen closed this Dec 11, 2024
@Boshen Boshen deleted the combined branch December 11, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant