perf: use as_os_str for Hash and PartialEq operations
#338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 96.94% 96.90% -0.05%
==========================================
Files 11 11
Lines 2458 2452 -6
==========================================
- Hits 2383 2376 -7
- Misses 75 76 +1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #338 will not alter performanceComparing Summary
|
Boshen
changed the title
as_os_str for Hash and PartialEq operations
This was referenced Dec 11, 2024
Merged
Boshen
added a commit
that referenced
this pull request
Dec 12, 2024
## 🤖 New release * `oxc_resolver`: 2.1.1 -> 3.0.0 (⚠️ API breaking changes) ###⚠️ `oxc_resolver` breaking changes ``` --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.37.0/src/lints/trait_method_added.ron Failed in: trait method oxc_resolver::FileSystem::read_link in file /tmp/.tmptmsXac/oxc-resolver/src/file_system.rs:52 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.37.0/src/lints/trait_method_missing.ron Failed in: method canonicalize of trait FileSystem, previously in file /tmp/.tmpa9nJqt/oxc_resolver/src/file_system.rs:62 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [3.0.0](oxc_resolver-v2.1.1...oxc_resolver-v3.0.0) - 2024-12-12 ### Added - [**breaking**] replace `FileSystem::canonicalize` with `FileSystem::read_link` (#331) - faster and stable path hash for the cache (#328) ### Other - guard `load_alias` on hot path (#339) - use `as_os_str` for `Hash` and `PartialEq` operations (#338) - run clippy with `--all-targets` (#333) - increase hash size (#329) - add dprint (#326) - update dependencies - *(deps)* update rust crates - update README logo </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.