Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try browsers field and alias before resolving directory in node_modules #349

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 14, 2024

No description provided.

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.07%. Comparing base (e1b0118) to head (9a7076c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   96.13%   96.07%   -0.06%     
==========================================
  Files          11       11              
  Lines        2483     2499      +16     
==========================================
+ Hits         2387     2401      +14     
- Misses         96       98       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 14, 2024

CodSpeed Performance Report

Merging #349 will not alter performance

Comparing 12-14-fix_try_browsers_field_and_alias_before_resolving_directory_in_node_modules (9a7076c) with main (e1b0118)

Summary

✅ 3 untouched benchmarks

@Boshen Boshen merged commit 5ede59d into main Dec 14, 2024
16 checks passed
@Boshen Boshen deleted the 12-14-fix_try_browsers_field_and_alias_before_resolving_directory_in_node_modules branch December 14, 2024 07:12
@oxc-bot oxc-bot mentioned this pull request Dec 14, 2024
Boshen pushed a commit that referenced this pull request Dec 14, 2024
## 🤖 New release
* `oxc_resolver`: 3.0.2 -> 3.0.3 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[3.0.3](oxc_resolver-v3.0.2...oxc_resolver-v3.0.3)
- 2024-12-14

### <!-- 1 -->Bug Fixes

- try browsers field and alias before resolving directory in
node_modules (#349)
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
@oxc-bot oxc-bot mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant