feat!: generic fs cache type Resolver = ResolverGeneric<FsCache<FileSystemOs>>

[arendjr]

This PR makes the cache fully generic by introducing a Cache trait, and renaming the existing Cache to FsCache.

The FileSystem trait still exists, but is only relevant still for users of FsCache. By keeping the trait, I hope to minimize the amount of breaking changes, even though some still remain.

The most notable breaking change is that ResolverGeneric::new_with_file_system(fs, ...) has become ResolverGeneric::new_with_cache(Arc::new(FsCache::new(fs)), ...).

Both FsCache and FileSystem are now behind a fs_cache feature flag, which is enabled by default.

I am actually considering to make both the PackageJson and TsConfig types generic as well (Biome already has its own, which ideally we would use directly for our custom Cache implementation). This should be achievable by introducing traits for them and adding them as associated types to the Cache trait. But before going too deep, I was hoping to first get feedback on the work so far :)

[codspeed-hq]

CodSpeed Performance Report

Merging #358 will not alter performance

_{Comparing arendjr:generic-cache (feefbfd) with main (fede8dc)}

Summary

✅ 3 untouched benchmarks

[Boshen]

I can start integrating with Oxc and Rolldown once test passes.

[arendjr]

What do you think about making PackageJson and TsConfig traits too? I can do it now, so you only need to update once, or we can iterate on it so this PR doesn't become too big.

[arendjr]

Btw, I've come pretty far implementing a cache for Biome based on this PR, but it looks like I do need PackageJson and TsConfig traits now to make meaningful progress. I can do that on a separate PR on top of this one.

[Boshen]

A package.json + tsconfig.json trait is inevitable, let's do it!

[Boshen]

I've successfully tested this change in oxc and Rolldown, let's merge after CI passes!

[arendjr]

Pushed a fix that I think will turn the Windows build green.

[Boshen]

Thank you so much for working on this!