fix(isolated-declarations): should be added to references, not bindin…

…gs (#3726)
oxc-project · Jun 17, 2024 · 0fbecdc · 0fbecdc
1 parent 8f64d99
commit 0fbecdc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/crates/oxc_isolated_declarations/src/scope.rs b/crates/oxc_isolated_declarations/src/scope.rs
@@ -133,8 +133,8 @@ impl<'a> Visit<'a> for ScopeTree<'a> {
 
     fn visit_export_default_declaration(&mut self, decl: &ExportDefaultDeclaration<'a>) {
         if let ExportDefaultDeclarationKind::Identifier(ident) = &decl.declaration {
-            self.add_type_binding(&ident.name);
-            self.add_value_binding(&ident.name);
+            self.add_type_reference(&ident.name);
+            self.add_value_reference(&ident.name);
         } else {
             walk_export_default_declaration(self, decl);
         }

diff --git a/tasks/coverage/transpile.snap b/tasks/coverage/transpile.snap
@@ -2,7 +2,7 @@ commit: d8086f14
 
 transpile Summary:
 AST Parsed     : 20/20 (100.00%)
-Positive Passed: 8/20 (40.00%)
+Positive Passed: 9/20 (45.00%)
 Mismatch: "declarationAsyncAndGeneratorFunctions.ts"
 Mismatch: "declarationBasicSyntax.ts"
 Mismatch: "declarationComputedPropertyNames.ts"
@@ -14,4 +14,3 @@ Mismatch: "declarationPartialNodeReuseTypeOf.ts"
 Mismatch: "declarationRestParameters.ts"
 Mismatch: "declarationSingleFileHasErrors.ts"
 Mismatch: "declarationSingleFileHasErrorsReported.ts"
-Mismatch: "declarationsSimple.ts"