fix(codegen): print type parameters for MethodDefinition (#3922)

close: #3918
oxc-project · Jun 26, 2024 · 2766594 · 2766594
1 parent 27f0531
commit 2766594
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/crates/oxc_codegen/src/gen.rs b/crates/oxc_codegen/src/gen.rs
@@ -2410,6 +2410,9 @@ impl<'a, const MINIFY: bool> Gen<MINIFY> for MethodDefinition<'a> {
         if self.computed {
             p.print(b']');
         }
+        if let Some(type_parameters) = self.value.type_parameters.as_ref() {
+            type_parameters.gen(p, ctx);
+        }
         p.print(b'(');
         self.value.params.gen(p, ctx);
         p.print(b')');

diff --git a/crates/oxc_isolated_declarations/tests/fixtures/class.ts b/crates/oxc_isolated_declarations/tests/fixtures/class.ts
@@ -4,4 +4,6 @@ export class Foo {
 
 export class Bar {
   public constructor(a: number = 0) {}
-}
+}
+
+export class Zoo { foo<F>(f: F): F { return f } }
diff --git a/crates/oxc_isolated_declarations/tests/snapshots/class.snap b/crates/oxc_isolated_declarations/tests/snapshots/class.snap
@@ -10,3 +10,6 @@ export declare class Foo {
 export declare class Bar {
 	constructor(a?: number);
 }
+export declare class Zoo {
+	foo<F>(f: F): F;
+}