Skip to content

Commit

Permalink
refactor(transformer): HelperLoader common transform: remove Rcs (#…
Browse files Browse the repository at this point in the history
…6564)

State is uniquely owned by `HelperLoaderStore`, so no need for `Rc`.
  • Loading branch information
overlookmotel committed Oct 15, 2024
1 parent 1c1e9fc commit 50ecade
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions crates/oxc_transformer/src/common/helper_loader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
use std::{
borrow::Cow,
cell::{Cell, RefCell},
rc::Rc,
};

use oxc_allocator::Vec;
Expand Down Expand Up @@ -154,9 +153,9 @@ pub struct HelperLoaderStore<'a> {
mode: HelperLoaderMode,
module_name: Cow<'static, str>,
/// Symbol ID for the `babelHelpers`.
babel_helpers_symbol_id: Rc<Cell<Option<SymbolId>>>,
babel_helpers_symbol_id: Cell<Option<SymbolId>>,
/// Loaded helpers, determined what helpers are loaded and what imports should be added.
loaded_helpers: Rc<RefCell<LoadedHelper<'a>>>,
loaded_helpers: RefCell<LoadedHelper<'a>>,
}

// Public methods
Expand All @@ -165,8 +164,8 @@ impl<'a> HelperLoaderStore<'a> {
Self {
mode: options.mode,
module_name: options.module_name.clone(),
loaded_helpers: Rc::new(RefCell::new(FxHashMap::default())),
babel_helpers_symbol_id: Rc::new(Cell::new(None)),
loaded_helpers: RefCell::new(FxHashMap::default()),
babel_helpers_symbol_id: Cell::new(None),
}
}

Expand Down

0 comments on commit 50ecade

Please sign in to comment.