refactor: use parent() instead of find.

oxc-project · Oct 2, 2024 · 63d18f8 · 63d18f8
1 parent 707d6ff
commit 63d18f8
Showing 1 changed file with 11 additions and 18 deletions.
diff --git a/crates/oxc_minifier/src/ast_passes/peephole_substitute_alternate_syntax.rs b/crates/oxc_minifier/src/ast_passes/peephole_substitute_alternate_syntax.rs
@@ -171,24 +171,17 @@ impl<'a> PeepholeSubstituteAlternateSyntax {
     fn compress_boolean(&mut self, expr: &mut Expression<'a>, ctx: &mut TraverseCtx<'a>) -> bool {
         let Expression::BooleanLiteral(lit) = expr else { return false };
         if self.options.booleans && !self.in_define_export {
-            let no_unary = ctx
-                .ancestry
-                .ancestors()
-                .map(|a| {
-                    if let Ancestor::BinaryExpressionRight(r) = a {
-                        let operator = r.operator();
-                        !matches!(
-                            operator,
-                            BinaryOperator::Addition
-                                | BinaryOperator::Instanceof
-                                | BinaryOperator::In
-                        )
-                    } else {
-                        false
-                    }
-                })
-                .next()
-                .unwrap_or(false);
+            let parent = ctx.ancestry.parent();
+            let no_unary = {
+                if let Ancestor::BinaryExpressionRight(u) = parent {
+                    !matches!(
+                        u.operator(),
+                        BinaryOperator::Addition | BinaryOperator::Instanceof | BinaryOperator::In
+                    )
+                } else {
+                    false
+                }
+            };
             // XOR: We should use `!neg` when it is not in binary expression.
             let num = ctx.ast.expression_numeric_literal(
                 SPAN,