fix(minifier): Unknown.fromCharCode should not be treated as `Strin…

…g.fromCharCode`
oxc-project · Jan 25, 2025 · c82f04d · c82f04d
1 parent f15bdce
commit c82f04d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/crates/oxc_minifier/src/peephole/replace_known_methods.rs b/crates/oxc_minifier/src/peephole/replace_known_methods.rs
@@ -245,7 +245,7 @@ impl<'a> PeepholeOptimizations {
     ) -> Option<Expression<'a>> {
         let Expression::Identifier(ident) = object else { return None };
         let ctx = Ctx(ctx);
-        if !ctx.is_global_reference(ident) {
+        if ident.name != "String" || !ctx.is_global_reference(ident) {
             return None;
         }
         let args = &ce.arguments;
@@ -1422,6 +1422,8 @@ mod test {
         test_same("String.fromCharCode(x)");
         test("x = String.fromCharCode('x')", "x = '\\0'");
         test("x = String.fromCharCode('0.5')", "x = '\\0'");
+
+        test_same("x = Unknown.fromCharCode('0.5')");
     }
 
     #[test]