Skip to content

Commit

Permalink
perf(linter): Remove sorting of rules in cache (#8718)
Browse files Browse the repository at this point in the history
Experimentally removing this sort as the TODO indicated this might not be needed. If there's no performance loss, I'd say we should merge it.
  • Loading branch information
camchenry committed Jan 25, 2025
1 parent 58002e2 commit d318238
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions crates/oxc_linter/src/config/config_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ impl RulesCache {
"Cannot re-initialize a populated rules cache. It must be cleared first."
);

let mut all_rules: Vec<_> = if self.plugins.is_all() {
let all_rules: Vec<_> = if self.plugins.is_all() {
RULES.clone()
} else {
let mut plugins = self.plugins;
Expand All @@ -410,7 +410,6 @@ impl RulesCache {
.cloned()
.collect()
};
all_rules.sort_unstable(); // TODO: do we need to sort? is is already sorted?

*self.all_rules.borrow_mut() = Some(all_rules);
}
Expand Down

0 comments on commit d318238

Please sign in to comment.