fix(parser): allow line breaks between const and enum (#8193)

https://www.typescriptlang.org/play/?ts=5.7.2#code/MYewdgzgLgUApmArgWwAQEFUG8C+Mg
oxc-project · Dec 31, 2024 · f88acb3 · f88acb3
1 parent ccaa9f7
commit f88acb3
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 9 deletions.
diff --git a/crates/oxc_parser/src/modifiers.rs b/crates/oxc_parser/src/modifiers.rs
@@ -318,7 +318,7 @@ impl<'a> ParserImpl<'a> {
         }
 
         match self.cur_kind() {
-            Kind::Const => !self.peek_token().is_on_new_line && self.peek_kind() == Kind::Enum,
+            Kind::Const => self.peek_kind() == Kind::Enum,
             Kind::Export => {
                 self.bump_any();
                 match self.cur_kind() {

diff --git a/tasks/coverage/misc/pass/oxc-8193.ts b/tasks/coverage/misc/pass/oxc-8193.ts
@@ -0,0 +1,2 @@
+const
+enum A {}
diff --git a/tasks/coverage/snapshots/codegen_misc.snap b/tasks/coverage/snapshots/codegen_misc.snap
@@ -1,3 +1,3 @@
 codegen_misc Summary:
-AST Parsed     : 30/30 (100.00%)
-Positive Passed: 30/30 (100.00%)
+AST Parsed     : 31/31 (100.00%)
+Positive Passed: 31/31 (100.00%)
diff --git a/tasks/coverage/snapshots/parser_misc.snap b/tasks/coverage/snapshots/parser_misc.snap
@@ -1,6 +1,6 @@
 parser_misc Summary:
-AST Parsed     : 30/30 (100.00%)
-Positive Passed: 30/30 (100.00%)
+AST Parsed     : 31/31 (100.00%)
+Positive Passed: 31/31 (100.00%)
 Negative Passed: 26/26 (100.00%)
 
   × Unexpected token

diff --git a/tasks/coverage/snapshots/semantic_misc.snap b/tasks/coverage/snapshots/semantic_misc.snap
@@ -1,6 +1,6 @@
 semantic_misc Summary:
-AST Parsed     : 30/30 (100.00%)
-Positive Passed: 19/30 (63.33%)
+AST Parsed     : 31/31 (100.00%)
+Positive Passed: 19/31 (61.29%)
 tasks/coverage/misc/pass/oxc-1288.ts
 semantic error: Bindings mismatch:
 after transform: ScopeId(0): ["from"]
@@ -170,3 +170,11 @@ semantic error: Scope children mismatch:
 after transform: ScopeId(0): [ScopeId(1), ScopeId(2), ScopeId(3)]
 rebuilt        : ScopeId(0): [ScopeId(1), ScopeId(2)]
 
+tasks/coverage/misc/pass/oxc-8193.ts
+semantic error: Scope flags mismatch:
+after transform: ScopeId(1): ScopeFlags(StrictMode)
+rebuilt        : ScopeId(1): ScopeFlags(StrictMode | Function)
+Symbol flags mismatch for "A":
+after transform: SymbolId(0): SymbolFlags(ConstEnum)
+rebuilt        : SymbolId(0): SymbolFlags(FunctionScopedVariable)
+
diff --git a/tasks/coverage/snapshots/transformer_misc.snap b/tasks/coverage/snapshots/transformer_misc.snap
@@ -1,3 +1,3 @@
 transformer_misc Summary:
-AST Parsed     : 30/30 (100.00%)
-Positive Passed: 30/30 (100.00%)
+AST Parsed     : 31/31 (100.00%)
+Positive Passed: 31/31 (100.00%)