GitHub action check annotation

[Boshen]

Biome has implemented this: https://biomejs.dev/blog/biome-v1-5/#the-command-biome-ci-now-prints-diagnostics-in-github-prs

[jbergstroem]

@Boshen another approach could be to check in the environment for GITHUB_ACTION and output the ::error string(s) as part of stdout. That way you' run the binary in CI and it'd Just Work.

[re-taro]

@Boshen Hello! I would like to address this issue!

[Boshen]

@Boshen Hello! I would like to address this issue!

Assigned 😁

[re-taro]

@Boshen Hello! I would like to address this issue!

Assigned 😁

Thanks! By the way, where should I create a repository?

• First, I'll create it privately, and if @Boshen decides it's a good idea, I'll import it into oxc-project.
• Create it in oxc-project from the beginning

[Boshen]

@re-taro Do you wanna take a look at how biome does it? It seems like all we need to do is detect for github CI and dump things differently

@Boshen another approach could be to check in the environment for GITHUB_ACTION and output the ::error string(s) as part of stdout. That way you' run the binary in CI and it'd Just Work.

[Boshen]

The text should be wrapped here I think

oxc/crates/oxc_diagnostics/src/service.rs

Line 127 in 4cd5f1a

output.push_str(&err);

[re-taro]

@re-taro Do you wanna take a look at how biome does it? It seems like all we need to do is detect for github CI and dump things differently

@Boshen another approach could be to check in the environment for GITHUB_ACTION and output the ::error string(s) as part of stdout. That way you' run the binary in CI and it'd Just Work.

Ah, I see, my apologies, you mean to respond with a Biome-like approach. Yes, sir.

[re-taro]

hmm... If you can escape &err_str and get file name, line number and column number in output.push_str(&err_str); inside crates/oxc_diagnostics/src/service.rs It would be nice, but it is not simple because line number and column number are obtained in crates/oxc_diagnostics/src/graphic_reporter.rs and are nicely hidden.

[Boshen]

hmm... If you can escape &err_str and get file name, line number and column number in output.push_str(&err_str); inside crates/oxc_diagnostics/src/service.rs It would be nice, but it is not simple because line number and column number are obtained in crates/oxc_diagnostics/src/graphic_reporter.rs and are nicely hidden.

Can you help me with what's needed to be printed / outputted on the screen?

[jbergstroem]

Can you help me with what's needed to be printed / outputted on the screen?

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-notice-message

[re-taro]

Sorry for the hassle. As @jbergstroem posted the link, you need to get the file name, column number and line number inside crates/oxc_diagnostics/src/service.rs (if you wrap output.push_ str(&err_str); if you wrap it...). For workflow-command, you can get it from diagnostic.severity().