Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(linter): replace string operations with cow_utils::CowUtils #5586

Closed
Boshen opened this issue Sep 7, 2024 · 1 comment
Closed

perf(linter): replace string operations with cow_utils::CowUtils #5586

Boshen opened this issue Sep 7, 2024 · 1 comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request good first issue Experience Level - Good for newcomers

Comments

@Boshen
Copy link
Member

Boshen commented Sep 7, 2024

I noticed we have many allocation methods which can be replaced by

https://docs.rs/cow-utils/0.1.3/cow_utils/trait.CowUtils.html

Feel free to grep them in the oxc_linter crate and make improvements. You may find inefficient routines in the process, feel free to make separate PRs.
@Boshen Boshen added C-enhancement Category - New feature or request good first issue Experience Level - Good for newcomers A-linter Area - Linter labels Sep 7, 2024
@heygsc heygsc mentioned this issue Sep 9, 2024
Merged
Boshen pushed a commit that referenced this issue Sep 9, 2024
@heygsc @autofix-ci
perf(linter): use cow_utils in no_script_url (#5633)
a0370bf 
part of #5586 

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@heygsc heygsc mentioned this issue Sep 9, 2024
Merged
Boshen pushed a commit that referenced this issue Sep 9, 2024
@heygsc
perf(linter): use cow_to_ascii_lowercase/uppercase (#5637)
e3ae5db 
part of #5586 

In addition, can a similar situation in the
[formatter](https://github.com/oxc-project/oxc/blob/main/crates/oxc_prettier/src/format/mod.rs#L1406-L1409)
be handled in this way?
@shulaoda shulaoda mentioned this issue Sep 9, 2024
Merged
@heygsc heygsc mentioned this issue Sep 9, 2024
Merged
Boshen pushed a commit that referenced this issue Sep 9, 2024
@shulaoda
perf(linter): use cow_replace instead of replace (#5643)
bfe9186 
Related to #5586
Boshen added a commit that referenced this issue Sep 10, 2024
@heygsc @autofix-ci @Boshen
perf(formatter): use cow and put cow_ascii on clippy (#5646)
febb29f 
close: #5639 

part of: #5586

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Boshen <boshenc@gmail.com>
@Boshen Boshen mentioned this issue Sep 10, 2024
Closed
@heygsc heygsc mentioned this issue Sep 10, 2024
Closed
@Boshen
Copy link
Member Author

Boshen commented Sep 10, 2024 •
edited
Loading

The remaining cases in #5662 should be fixed. Feel free to use the PR as the base and make changes.

@shulaoda shulaoda mentioned this issue Sep 10, 2024
Merged
Boshen added a commit that referenced this issue Sep 11, 2024
@shulaoda @Boshen
perf(rust): use cow_utils instead (#5664)
d18c896 
Related to #5586 and #5662

---------

Co-authored-by: Boshen <boshenc@gmail.com>
@Boshen Boshen closed this as completed Sep 11, 2024
This was referenced Sep 15, 2024
Merged
Merged
@minht11 minht11 mentioned this issue Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linter Area - Linter C-enhancement Category - New feature or request good first issue Experience Level - Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(linter): forbid string allocation methods such as to_lowercase and replace oxc-project/oxc
1 participant
@Boshen