Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regular expression: some incorrect codegen #6413

Closed
Boshen opened this issue Oct 10, 2024 · 1 comment · Fixed by #6524
Closed

regular expression: some incorrect codegen #6413

Boshen opened this issue Oct 10, 2024 · 1 comment · Fixed by #6524
Labels
C-bug Category - Bug good first issue Experience Level - Good for newcomers

Comments

@Boshen
Copy link
Member

Boshen commented Oct 10, 2024 •
edited by leaysgur
Loading

See #6411

Expect to Parse: tasks/coverage/test262/test/built-ins/String/prototype/split/separator-regexp.js

  × Regular Expression content mismatch for `/\cY/`: `\c�` == `\c�`
@Boshen Boshen added C-bug Category - Bug good first issue Experience Level - Good for newcomers labels Oct 10, 2024
@leaysgur leaysgur mentioned this issue Oct 10, 2024
Merged
Boshen pushed a commit that referenced this issue Oct 10, 2024
@leaysgur
fix(regular_expression): Fix CharacterClass negative codegen (#6415)
c822b48 
Part of #6413 , fixes these mismatch.

```
  × Regular Expression content mismatch for `/[^]a/m`: `[]a` == `[]a`
  × Regular Expression content mismatch for `/a[^]/`: `a[]` == `a[]`
  × Regular Expression content mismatch for `/[^]/`: `[]` == `[]`
  × Regular Expression content mismatch for `/[^]/`: `[]` == `[]`
```
@Boshen
Copy link
Member Author

Boshen commented Oct 13, 2024

Last case: https://github.com/oxc-project/oxc/blob/c56343d1f3098364e04866da18e6d169671f7acc/tasks/coverage/snapshots/parser_test262.snap#L9

@tapanprakasht tapanprakasht mentioned this issue Oct 13, 2024
Merged
Boshen pushed a commit that referenced this issue Oct 14, 2024
@tapanprakasht
fix(regular_expression): Fixed control Y regular expression (#6524)
9f9057b 
Fixes #6413

Fixed regular expression for control Y
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category - Bug good first issue Experience Level - Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(regular_expression): Fixed control Y regular expression tapanprakasht/oxc
1 participant
@Boshen