Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: add source_text, trivias to Program? #6426

Closed
Boshen opened this issue Oct 10, 2024 · 1 comment
Closed

API: add source_text, trivias to Program? #6426

Boshen opened this issue Oct 10, 2024 · 1 comment
Assignees
@Boshen
Labels
needs-discussion Requires a discussion from the core team

Comments

@Boshen
Copy link
Member

Boshen commented Oct 10, 2024

Why do I need to return them separately from ParserReturn and then pass them around to other components? Why can't they stay with Program?

I think I was distracted by how Program needs to be serialized to estree. But we can just skip serializing these data.
@Boshen Boshen added the C-enhancement Category - New feature or request label Oct 10, 2024
@Boshen Boshen self-assigned this Oct 10, 2024
@Boshen Boshen added needs-discussion Requires a discussion from the core team and removed C-enhancement Category - New feature or request labels Oct 10, 2024
This was referenced Oct 10, 2024
Closed
Merged
Merged
Merged
Boshen added a commit that referenced this issue Oct 11, 2024
@Boshen
refactor(oxc)!: remove passing Trivias around (#6446)
5200960 
part of #6426
@Boshen Boshen closed this as completed Oct 11, 2024
@Boshen
Copy link
Member Author

Boshen commented Oct 11, 2024

What about source_path?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
needs-discussion Requires a discussion from the core team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Boshen