-
-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convention for field order in AST types #6453
Comments
Boshen
added
needs-discussion
Requires a discussion from the core team
and removed
C-bug
Category - Bug
labels
Oct 11, 2024
Evaluation order defined in the spec. For types, we look at how it's defined in tsc. |
Reopening this just for the action point of adding this info to the docs. |
Boshen
added a commit
that referenced
this issue
Oct 24, 2024
overlookmotel
pushed a commit
that referenced
this issue
Oct 25, 2024
Boshen
added a commit
that referenced
this issue
Oct 25, 2024
Orenbek
pushed a commit
to Orenbek/oxc
that referenced
this issue
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I opened #6391 to re-order fields on some types so they're in source order. I had assumed:
@Boshen replied:
Opening this issue to resolve question of what is our convention, so that we can document it.
A couple of questions:
What does "runtime order" mean exactly? The order of runtime evaluation?
Are there any cases where source order and runtime order are different? I can't immediately think of any, but JS is weird - there may well be some obscure cases where they're different.
The text was updated successfully, but these errors were encountered: