Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include ZWSP in irregular whitespace? #6646

Closed
overlookmotel opened this issue Oct 17, 2024 · 2 comments · Fixed by #6662
Closed

Include ZWSP in irregular whitespace? #6646

overlookmotel opened this issue Oct 17, 2024 · 2 comments · Fixed by #6662
Assignees
@Boshen
Labels
A-parser Area - Parser C-bug Category - Bug

Comments

@overlookmotel
Copy link
Contributor

#6639 turned up an odd anomaly.

The definition of "whitespace" used by TypeScript matches ours except for 1 character - ZWSP (\u{200b}).

Should this character be included in the group matched by is_irregular_whitespace?
@overlookmotel overlookmotel added C-bug Category - Bug A-parser Area - Parser labels Oct 17, 2024
@overlookmotel overlookmotel mentioned this issue Oct 17, 2024
Merged
@Boshen
Copy link
Member

Boshen commented Oct 17, 2024

Context: https://eslint.org/docs/latest/rules/no-irregular-whitespace

It should be included.

@Boshen
Copy link
Member

Boshen commented Oct 18, 2024 •
edited
Loading

oxc/crates/oxc_syntax/src/identifier.rs

Line 59 in 9d43a11

..ZWSP | NNBSP | MMSP | IDEOGRAPHIC_SPACE

It was a mistake with the range operator, should be ..=

Boshen added a commit that referenced this issue Oct 18, 2024
@Boshen
refactor(identifier): remove comment regarding ZWSP for `is_white_s…
16e4ffe 
…pace_single_line`

closes #6646
Boshen added a commit that referenced this issue Oct 18, 2024
@Boshen
refactor(identifier): add ZWSP to is_irregular_whitespace
04baf3c 
closes #6646
@Boshen Boshen mentioned this issue Oct 18, 2024
Merged
Boshen added a commit that referenced this issue Oct 18, 2024
@Boshen
fix(identifier): add ZWSP to is_irregular_whitespace (#6662)
2ce3e5f 
closes #6646
@Boshen Boshen closed this as completed Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
A-parser Area - Parser C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(identifier): add ZWSP to is_irregular_whitespace oxc-project/oxc
2 participants
@overlookmotel @Boshen