Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter: declare_all_lint_rules! macro naming collision between modules #7082

Closed
pumano opened this issue Nov 1, 2024 · 1 comment
Closed

linter: declare_all_lint_rules! macro naming collision between modules #7082

pumano opened this issue Nov 1, 2024 · 1 comment
Assignees
@Boshen
Labels
A-linter Area - Linter C-bug Category - Bug

Comments

@pumano
Copy link
Contributor

pumano commented Nov 1, 2024

What version of Oxlint are you using?

0.10.3

What command did you run?

No response

What does your .oxlint.json config file look like?

No response

What happened?

It's impossible to expose rules for example import/no-namespace rule due to naming collision with typescript/no-namespace in declare_all_lint_rules! macro
@pumano pumano added A-linter Area - Linter C-bug Category - Bug labels Nov 1, 2024
@no-yan no-yan mentioned this issue Nov 5, 2024
Closed
@Boshen Boshen self-assigned this Nov 11, 2024
@camchenry camchenry mentioned this issue Nov 12, 2024
Merged
Boshen pushed a commit that referenced this issue Nov 13, 2024
@camchenry
fix(linter): revert unmatched rule error (#7257)
df5c535 
- related to #6988

This is causing a lot of errors currently such as
#7233. I think we need to
handle rule names more robustly first:

- #7240
- #7082
- #7242

then, I think we can revisit this and maybe implement it as an actual
lint plugin too? #7086
Dunqing pushed a commit that referenced this issue Nov 17, 2024
@camchenry @Dunqing
fix(linter): revert unmatched rule error (#7257)
cac1fc9 
- related to #6988

This is causing a lot of errors currently such as
#7233. I think we need to
handle rule names more robustly first:

- #7240
- #7082
- #7242

then, I think we can revisit this and maybe implement it as an actual
lint plugin too? #7086
Dunqing pushed a commit that referenced this issue Nov 18, 2024
@camchenry @Dunqing
fix(linter): revert unmatched rule error (#7257)
e93cc66 
- related to #6988

This is causing a lot of errors currently such as
#7233. I think we need to
handle rule names more robustly first:

- #7240
- #7082
- #7242

then, I think we can revisit this and maybe implement it as an actual
lint plugin too? #7086
Dunqing pushed a commit that referenced this issue Nov 18, 2024
@camchenry @Dunqing
fix(linter): revert unmatched rule error (#7257)
70a2c12 
- related to #6988

This is causing a lot of errors currently such as
#7233. I think we need to
handle rule names more robustly first:

- #7240
- #7082
- #7242

then, I think we can revisit this and maybe implement it as an actual
lint plugin too? #7086
@Sysix
Copy link
Collaborator

Sysix commented Nov 28, 2024

is fixed with #7496

tested it in snapshot eslint-plugin-eslint: https://github.com/oxc-project/eslint-plugin-oxlint/pull/262/files#diff-ff389c66187cc169595103ea27c278a8cd64c4bd64570834fcee87b9aafd1fa4R289-R291

@Sysix Sysix closed this as completed Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Boshen @Sysix @pumano