Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linter): ignorePatterns does not work when files are provided as command arguments #8590

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(linter): ignorePatterns does not work when files are provided as command arguments #8590

wants to merge 6 commits into from
+144 −52

Conversation

shulaoda
Copy link
Contributor

closes #8505

Here is why this issue occurs:

oxc/apps/oxlint/src/lint.rs

Lines 66 to 70 in c15af02

// The ignore crate whitelists explicit paths, but priority
// should be given to the ignore file. Many users lint
// automatically and pass a list of changed files explicitly.
// To accommodate this, unless `--no-ignore` is passed,
// pre-filter the paths.

@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-cli Area - CLI C-bug Category - Bug labels Jan 18, 2025
@shulaoda shulaoda marked this pull request as draft January 18, 2025 23:45
shulaoda
shulaoda commented Jan 18, 2025
View reviewed changes
apps/oxlint/src/lint.rs Outdated Show resolved Hide resolved
@shulaoda shulaoda marked this pull request as ready for review January 18, 2025 23:58
@shulaoda shulaoda marked this pull request as draft January 19, 2025 13:45
@shulaoda shulaoda force-pushed the fix/oxlintrc-ignore-patterns branch 3 times, most recently from 961ffc9 to c3fc238 Compare January 26, 2025 05:44
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 26, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8590 will not alter performance

Comparing shulaoda:fix/oxlintrc-ignore-patterns (1e6f76f) with main (e85827b)

Summary

✅ 33 untouched benchmarks

@shulaoda shulaoda marked this pull request as ready for review January 26, 2025 05:52
@shulaoda shulaoda requested a review from Sysix January 26, 2025 05:52
@shulaoda shulaoda force-pushed the fix/oxlintrc-ignore-patterns branch from 44b0c3f to 3466e26 Compare January 26, 2025 10:30
Sysix
Sysix reviewed Jan 26, 2025
View reviewed changes
apps/oxlint/src/lint.rs Outdated Show resolved Hide resolved
apps/oxlint/src/lint.rs Outdated Show resolved Hide resolved
apps/oxlint/src/lint.rs Outdated Show resolved Hide resolved
@shulaoda shulaoda force-pushed the fix/oxlintrc-ignore-patterns branch from 26bded3 to 2fa3bc6 Compare January 26, 2025 14:33
@shulaoda shulaoda marked this pull request as draft January 26, 2025 14:37
@shulaoda shulaoda marked this pull request as ready for review January 26, 2025 14:51
@shulaoda shulaoda force-pushed the fix/oxlintrc-ignore-patterns branch from b32f339 to 1e6f76f Compare January 26, 2025 14:54
@shulaoda shulaoda requested a review from Sysix January 26, 2025 14:55
@Sysix Sysix requested a review from Boshen January 26, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sysix Sysix Sysix approved these changes

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
A-cli Area - CLI C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linter: ignorePatterns does not work when files are provided as command arguments
2 participants
@shulaoda @Sysix