fix(linter): `ignorePatterns` does not work when files are provided as command arguments #8590

shulaoda · 2025-01-18T23:37:31Z

Here is why this issue occurs:

Lines 66 to 70 in c15af02

    
           // The ignore crate whitelists explicit paths, but priority 
        
           // should be given to the ignore file. Many users lint 
        
           // automatically and pass a list of changed files explicitly. 
        
           // To accommodate this, unless `--no-ignore` is passed, 
        
           // pre-filter the paths.

graphite-app · 2025-01-18T23:37:37Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

apps/oxlint/src/lint.rs

codspeed-hq · 2025-01-26T05:51:20Z

CodSpeed Performance Report

Merging #8590 will not alter performance

_{Comparing shulaoda:fix/oxlintrc-ignore-patterns (ed83063) with main (fb5b1fa)}

Summary

✅ 33 untouched benchmarks

apps/oxlint/src/lint.rs

### Description ![image](https://github.com/user-attachments/assets/322b94a3-4056-46ba-8b7c-8abf9141ab02) If we run `just lint`, we will find that `oxlint` cannot correctly handle the `ignorePatterns` in the `.oxlintrc.json` file. Therefore, we temporarily revert to using `.oxlintignore`. Related to oxc-project/oxc#8590

…command arguments

## [0.15.9] - 2025-02-01 ### Features - 1a41181 linter: Implement `eslint/prefer-object-spread` (#8216) (tbashiyy) - adb8ebd linter: Implement no-useless-call rule (#8789) (keita hino) - 3790933 linter: Add vitest/prefer-lowercase-title rule (#8152) (Tyler Earls) - e8e6917 linter: Unicorn/switch-cases-braces support options (#8704) (1zumii) ### Bug Fixes - 8ce21d1 linter: Can't disable `no-nested-ternary` rule anymore (#8600) (dalaoshu) - e929f26 linter: Output `LintCommandInfo` for `CliRunResult::LintNoFilesFound` (#8714) (Sysix) - 4f30a17 linter: Unicorn/switch-case-braces mangles code when applying fix (#8758) (Tyler Earls) - 9cc9d5f linter: `ignorePatterns` does not work when files are provided as command arguments (#8590) (dalaoshu) - 1de6f85 linter: No-lone-blocks erroring on block statements containing comments (#8720) (Tyler Earls) - 77ef61a linter: Fix diagnostic spans for `oxc/no-async-await` (#8721) (camchenry) - f15bdce linter: Catch `Promise` in `typescript/array-type` rule (#8702) (Rintaro Itokawa) - 5041cb3 vscode: Fix commands by reverting commit `259a47b` (#8819) (Alexander S.) ### Performance - d318238 linter: Remove sorting of rules in cache (#8718) (camchenry) ### Documentation - 57b7ca8 ast: Add documentation for all remaining JS AST methods (#8820) (Cam McHenry) ### Refactor - c2fdfc4 linter: Correctly handle loose options for `eslint/eqeqeq` (#8798) (dalaoshu) - 0aeaedd linter: Support loose options for `eslint/eqeqeq` (#8790) (dalaoshu) - 194a5ff linter: Remove `LintResult` (#8712) (Sysix) - 4a2f2a9 linter: Move default `all_rules` output to trait (#8710) (Sysix) - 741fb40 linter: Move stdout outside LintRunner (#8694) (Sysix) - 10e5920 linter: Move finishing default diagnostic message to `GraphicalReporter` (#8683) (Sysix) - 9731c56 oxlint: Move output from `CliRunResult::InvalidOption` to outside and use more Enums for different invalid options (#8778) (Sysix) - fe45bee oxlint: Create different `CliRunResult` instead of passing `ExitCode` to it (#8777) (Sysix) - 2378fef oxlint: Move ConfigFileInit output outside CliRunResult, exit code 1 when it fails (#8776) (Sysix) - f4cecb5 oxlint: Remove unused `CliRunResult::PathNotFound` (#8775) (Sysix) ### Testing - ad35e82 linter: Use snapshot testing instead of LintResult (#8711) (Sysix) - bf895eb linter: Add diagnostic format test snapshots (#8696) (Alexander S.) - 34d3d72 linter: Add snapshot tester for cli (#8695) (Sysix) - 0bf2bcf oxlint: Test two real rules with same name but from different plugins (#8821) (dalaoshu) - 2b83b71 oxlint: Improve disabling "no-nested-ternary" tests (#8814) (Alexander S.) - 45648e7 oxlint: Fix InvalidOptionTsConfig tests for windows (#8791) (Alexander S.) - 48bfed9 oxlint: Ignore windows path mismatch (Boshen) - 6f4a023 oxlint: Remove "--print-config" test (#8792) (Sysix) - 55c2025 oxlint: Add `CliRunResult` to snapshot (#8780) (Sysix) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-cli Area - CLI C-bug Category - Bug labels Jan 18, 2025

shulaoda marked this pull request as draft January 18, 2025 23:45

shulaoda commented Jan 18, 2025

View reviewed changes

apps/oxlint/src/lint.rs Outdated Show resolved Hide resolved

shulaoda marked this pull request as ready for review January 18, 2025 23:58

shulaoda marked this pull request as draft January 19, 2025 13:45

shulaoda force-pushed the fix/oxlintrc-ignore-patterns branch 3 times, most recently from 961ffc9 to c3fc238 Compare January 26, 2025 05:44

shulaoda marked this pull request as ready for review January 26, 2025 05:52

shulaoda requested a review from Sysix January 26, 2025 05:52

shulaoda force-pushed the fix/oxlintrc-ignore-patterns branch from 44b0c3f to 3466e26 Compare January 26, 2025 10:30

Sysix reviewed Jan 26, 2025

View reviewed changes

apps/oxlint/src/lint.rs Outdated Show resolved Hide resolved

apps/oxlint/src/lint.rs Outdated Show resolved Hide resolved

apps/oxlint/src/lint.rs Outdated Show resolved Hide resolved

shulaoda force-pushed the fix/oxlintrc-ignore-patterns branch from 26bded3 to 2fa3bc6 Compare January 26, 2025 14:33

shulaoda marked this pull request as draft January 26, 2025 14:37

shulaoda marked this pull request as ready for review January 26, 2025 14:51

shulaoda force-pushed the fix/oxlintrc-ignore-patterns branch from b32f339 to 1e6f76f Compare January 26, 2025 14:54

shulaoda requested a review from Sysix January 26, 2025 14:55

Sysix approved these changes Jan 26, 2025

View reviewed changes

Sysix requested a review from Boshen January 26, 2025 15:15

shulaoda mentioned this pull request Jan 28, 2025

chore(oxlint): temporarily restore .oxlintignore rolldown/rolldown#3441

Merged

shulaoda force-pushed the fix/oxlintrc-ignore-patterns branch from 1e6f76f to 948d8a0 Compare January 30, 2025 10:28

shulaoda marked this pull request as draft January 30, 2025 10:29

shulaoda marked this pull request as ready for review January 30, 2025 10:40

shulaoda force-pushed the fix/oxlintrc-ignore-patterns branch from ed83063 to f681d73 Compare January 31, 2025 03:50

shulaoda added 2 commits January 31, 2025 11:51

fix(linter): ignorePatterns does not work when files are provided as …

f1c9027

…command arguments

test: add test cases

32c6e09

shulaoda added 6 commits January 31, 2025 11:51

fix

1f55a7e

chore: follow the suggestions

7a499f8

fix

312dee4

chore: use meaningful name

e3866f5

chore: resolve merge conflicts

3aefba2

fix

7798385

shulaoda force-pushed the fix/oxlintrc-ignore-patterns branch from ee76cc2 to 7798385 Compare January 31, 2025 03:51

Boshen merged commit 9cc9d5f into oxc-project:main Jan 31, 2025
14 checks passed

shulaoda deleted the fix/oxlintrc-ignore-patterns branch January 31, 2025 04:35

oxc-bot mentioned this pull request Feb 1, 2025

release(oxlint): v0.15.9 #8824

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(linter): `ignorePatterns` does not work when files are provided as command arguments #8590

fix(linter): `ignorePatterns` does not work when files are provided as command arguments #8590

shulaoda commented Jan 18, 2025

graphite-app bot commented Jan 18, 2025

codspeed-hq bot commented Jan 26, 2025 •

edited

Loading

	// The ignore crate whitelists explicit paths, but priority
	// should be given to the ignore file. Many users lint
	// automatically and pass a list of changed files explicitly.
	// To accommodate this, unless `--no-ignore` is passed,
	// pre-filter the paths.

fix(linter): ignorePatterns does not work when files are provided as command arguments #8590

fix(linter): ignorePatterns does not work when files are provided as command arguments #8590

Conversation

shulaoda commented Jan 18, 2025

graphite-app bot commented Jan 18, 2025

How to use the Graphite Merge Queue

codspeed-hq bot commented Jan 26, 2025 • edited Loading

CodSpeed Performance Report

Merging #8590 will not alter performance

Summary

fix(linter): `ignorePatterns` does not work when files are provided as command arguments #8590

fix(linter): `ignorePatterns` does not work when files are provided as command arguments #8590

codspeed-hq bot commented Jan 26, 2025 •

edited

Loading