Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): support unicorn/prefer-query-selector #1068

Merged
merged 9 commits into from
Oct 30, 2023
Merged

feat(linter): support unicorn/prefer-query-selector #1068

merged 9 commits into from
Oct 30, 2023

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 26, 2023

@github-actions github-actions bot added the A-linter Area - Linter label Oct 26, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 26, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #1068 will not alter performance

Comparing Dunqing:feat/linter/unicorn/prefer-query-selector (1a3b9a0) with main (6da5a3f)

Summary

✅ 22 untouched benchmarks

@Dunqing Dunqing marked this pull request as ready for review October 30, 2023 05:07
Boshen
Boshen reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed some other nitpicks, should be good to go after this change.

crates/oxc_linter/src/utils/unicorn.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/unicorn/prefer_query_selector.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/unicorn/prefer_query_selector.rs Outdated Show resolved Hide resolved
Boshen
Boshen approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Boshen Boshen merged commit d4c05ff into oxc-project:main Oct 30, 2023
@camc314 camc314 mentioned this pull request Nov 5, 2023
Open
@ezpuzz
Copy link

ezpuzz commented Dec 11, 2024

the fixer here is not correct, the arguments are different for getElementsByClassName and querySelectorAll. One is a list of class names and the other is a query selector.

@ezpuzz ezpuzz mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dunqing @ezpuzz @Boshen