Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add eslint-plugin-import(export) rule #1654

Merged

Conversation

mysteryven
Copy link
Member

No description provided.

Copy link
Member Author

mysteryven commented Dec 11, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@mysteryven mysteryven force-pushed the 12-11-feat_linter_add_eslint-plugin-import_export_rule branch from 3f96b0f to 3e2ff5e Compare December 12, 2023 04:32
@mysteryven mysteryven changed the base branch from main to 12-12-chore_ci_change_to_labeler-v5_s_style December 12, 2023 04:32
@github-actions github-actions bot added the A-linter Area - Linter label Dec 12, 2023
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's many more tests to port https://github.com/import-js/eslint-plugin-import/blob/main/tests/src/rules/export.js

shall we add a TODO for this and mark this as nursery?

Base automatically changed from 12-12-chore_ci_change_to_labeler-v5_s_style to main December 12, 2023 04:35
@mysteryven
Copy link
Member Author

shall we add a TODO for this and mark this as nursery?

I didn't know how I thought yesterday when I set to restriction,😿 I'll add this.

There's many more tests to port import-js/eslint-plugin-import@main/tests/src/rules/export.js

I am planing to add new rulegen for eslint-import-plugin.

@mysteryven mysteryven force-pushed the 12-11-feat_linter_add_eslint-plugin-import_export_rule branch 3 times, most recently from 11ef8ea to b2da49f Compare December 12, 2023 15:02
@mysteryven
Copy link
Member Author

shall we add a TODO for this and mark this as nursery?

Done.

@mysteryven mysteryven force-pushed the 12-11-feat_linter_add_eslint-plugin-import_export_rule branch from b2da49f to 6223e24 Compare December 12, 2023 15:03
Copy link

codspeed-hq bot commented Dec 12, 2023

CodSpeed Performance Report

Merging #1654 will not alter performance

Comparing 12-11-feat_linter_add_eslint-plugin-import_export_rule (c306f63) with main (282771a)

Summary

✅ 20 untouched benchmarks

@mysteryven mysteryven force-pushed the 12-11-feat_linter_add_eslint-plugin-import_export_rule branch from 6223e24 to c306f63 Compare December 13, 2023 12:39
@mysteryven mysteryven merged commit 90524c8 into main Dec 13, 2023
17 checks passed
@mysteryven mysteryven deleted the 12-11-feat_linter_add_eslint-plugin-import_export_rule branch December 13, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants