Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter) no double comparisons #1712

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

camc314
Copy link
Collaborator

@camc314 camc314 commented Dec 17, 2023

Copy link
Collaborator Author

camc314 commented Dec 17, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added the A-linter Area - Linter label Dec 17, 2023
@camc314 camc314 force-pushed the c/12-17-feat_linter_no_double_comparisons branch 2 times, most recently from 3a34573 to 7edca85 Compare December 17, 2023 22:46
Copy link

codspeed-hq bot commented Dec 17, 2023

CodSpeed Performance Report

Merging #1712 will not alter performance

Comparing c/12-17-feat_linter_no_double_comparisons (7b27adc) with main (de1d6ad)

Summary

✅ 20 untouched benchmarks

@Dunqing
Copy link
Member

Dunqing commented Dec 18, 2023

It looks like we can make this rule support auto-fix

Base automatically changed from c/12-17-feat_linter_const_comparisons to main December 19, 2023 10:50
@Boshen Boshen force-pushed the c/12-17-feat_linter_no_double_comparisons branch from 7edca85 to 7b27adc Compare December 19, 2023 10:52
@Boshen Boshen enabled auto-merge (squash) December 19, 2023 10:52
@Boshen Boshen merged commit 0a611ac into main Dec 19, 2023
15 checks passed
@Boshen Boshen deleted the c/12-17-feat_linter_no_double_comparisons branch December 19, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants