Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): eslint-plugin-react: no-direct-mutation-state #1892

Merged

Conversation

@github-actions github-actions bot added the A-linter Area - Linter label Jan 4, 2024
@zhangrunzhao zhangrunzhao force-pushed the react-no-direct-mutation-state branch 2 times, most recently from 97d8e95 to 268f2b8 Compare January 9, 2024 06:18
@zhangrunzhao zhangrunzhao marked this pull request as ready for review January 9, 2024 06:20
@zhangrunzhao
Copy link
Contributor Author

when i try to rebase main branch, throw a error.
wVcgn6sWXd

I could run normally before rebase, so I judged that it was not caused by me and initiated merge request

Copy link

codspeed-hq bot commented Jan 9, 2024

CodSpeed Performance Report

Merging #1892 will improve performances by 6.87%

Comparing zhangrunzhao:react-no-direct-mutation-state (d7c7689) with main (a6717db)

Summary

⚡ 1 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

Benchmark main zhangrunzhao:react-no-direct-mutation-state Change
semantic[pdf.mjs] 120.9 ms 113.2 ms +6.87%

@zhangrunzhao zhangrunzhao force-pushed the react-no-direct-mutation-state branch 3 times, most recently from 55ca4e6 to c550d96 Compare January 9, 2024 11:31
@camc314
Copy link
Collaborator

camc314 commented Jan 9, 2024

when i try to rebase main branch, throw a error. wVcgn6sWXd

I could run normally before rebase, so I judged that it was not caused by me and initiated merge request

Hmm - says it's a network error? does hitting https://index.crates.io work in a browser?

Edit: also CI passed so i think it's probably fine

@zhangrunzhao
Copy link
Contributor Author

when i try to rebase main branch, throw a error. wVcgn6sWXd
I could run normally before rebase, so I judged that it was not caused by me and initiated merge request

Hmm - says it's a network error? does hitting https://index.crates.io work in a browser?

Edit: also CI passed so i think it's probably fine

Running the cargo test on the main branch also results in an error, maybe it's my local network cause this error.

Copy link
Collaborator

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants