-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): eslint-plugin-react: no-direct-mutation-state #1892
Merged
camc314
merged 1 commit into
oxc-project:main
from
zhangrunzhao:react-no-direct-mutation-state
Jan 10, 2024
Merged
feat(linter): eslint-plugin-react: no-direct-mutation-state #1892
camc314
merged 1 commit into
oxc-project:main
from
zhangrunzhao:react-no-direct-mutation-state
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangrunzhao
force-pushed
the
react-no-direct-mutation-state
branch
2 times, most recently
from
January 9, 2024 06:18
97d8e95
to
268f2b8
Compare
CodSpeed Performance ReportMerging #1892 will improve performances by 6.87%Comparing Summary
Benchmarks breakdown
|
zhangrunzhao
force-pushed
the
react-no-direct-mutation-state
branch
3 times, most recently
from
January 9, 2024 11:31
55ca4e6
to
c550d96
Compare
camc314
reviewed
Jan 9, 2024
camc314
reviewed
Jan 9, 2024
zhangrunzhao
force-pushed
the
react-no-direct-mutation-state
branch
from
January 10, 2024 07:01
c550d96
to
d7c7689
Compare
camc314
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
…ect#1892) oxc-project#1022 Based on: - code: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/lib/rules/no-direct-mutation-state.js - doc: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-direct-mutation-state.md - test: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/tests/lib/rules/no-direct-mutation-state.js Co-authored-by: 张润钊 <zhangrunzhao@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1022
try to implement
no-direct-mutation-state