Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): eslint-plugin-jsx-a11y autocomplete-valid #1901

Merged
merged 2 commits into from
Jan 10, 2024
Merged

feat(linter): eslint-plugin-jsx-a11y autocomplete-valid #1901

merged 2 commits into from
Jan 10, 2024

Conversation

yossydev
Copy link

@yossydev yossydev commented Jan 5, 2024 •
edited
Loading

@github-actions github-actions bot added the A-linter Area - Linter label Jan 5, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 5, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1901 will not alter performance

Comparing yossydev:autocomplete-valid (bcb260f) with main (b5f4f1e)

Summary

✅ 14 untouched benchmarks

@camc314
Copy link
Collaborator

camc314 commented Jan 9, 2024 •
edited
Loading

Hey @yossydev !

this is looking good - need any help here to get this over the line?

@yossydev yossydev force-pushed the autocomplete-valid branch 2 times, most recently from 98d8b25 to 60159a3 Compare January 10, 2024 05:54
@yossydev yossydev marked this pull request as ready for review January 10, 2024 05:54
@yossydev
Copy link
Author

yossydev commented Jan 10, 2024 •
edited
Loading

@camc314
Sorry, I failed to open it!🙏
Please give us a review!💪

camc314
camc314 reviewed Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

once we've updated it to use phf this is good to go!

@yossydev yossydev requested a review from camc314 January 10, 2024 09:40
camc314
camc314 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314 camc314 merged commit ac704cc into oxc-project:main Jan 10, 2024
16 checks passed
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@IWANABETHATGUY
feat(linter): eslint-plugin-jsx-a11y autocomplete-valid (oxc-project#…
8ca1807 
…1901)

Part of: oxc-project#1141

Based on:
- doc: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/autocomplete-valid.md
- code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/autocomplete-valid.js
- test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/autocomplete-valid-test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yossydev @camc314