Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): implement react/require-render-return #1946

Merged
merged 1 commit into from
Jan 9, 2024
Merged

feat(linter): implement react/require-render-return #1946

merged 1 commit into from
Jan 9, 2024

Conversation

kaykdm
Copy link
Contributor

@kaykdm kaykdm commented Jan 8, 2024 •
edited
Loading

@github-actions github-actions bot added the A-linter Area - Linter label Jan 8, 2024
@XantreDev
Copy link
Contributor

XantreDev commented Jan 8, 2024 •
edited
Loading

I think you should add help info.
Description of PR is incorrect

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1946 will not alter performance

Comparing kaykdm:require-render-return (e943156) with main (6e0bd52)

Summary

✅ 14 untouched benchmarks

@Boshen Boshen requested a review from camc314 January 9, 2024 04:24
camc314
camc314 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314 camc314 enabled auto-merge (squash) January 9, 2024 22:50
@camc314 camc314 merged commit 7891670 into oxc-project:main Jan 9, 2024
16 checks passed
@kaykdm kaykdm deleted the require-render-return branch January 10, 2024 01:03
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@kaykdm @IWANABETHATGUY
feat(linter): eslint-plugin-react: require-render-return (oxc-project…
e5dc5e2 
…#1946)

Related issue: oxc-project#1022

Based on:
- doc: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/require-render-return.md
- code: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/lib/rules/require-render-return.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaykdm @XantreDev @camc314